Bug 1693891

Summary: Change warning message of network not supporting when PXE booting creating a new VM through network install
Product: [Community] Virtualization Tools Reporter: Gabriel <gabrielramirez1109>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED UPSTREAM QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, crobinso, gscrivan, tburke, vslknsgr
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-26 19:34:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gabriel 2019-03-28 22:48:39 UTC 
Description of problem:

Warning message should say something along the lines of "network may not support PXE boot"  

Steps to reproduce:


Create a NAT'd virtual network and create a guest with a NIC on that virtual network.  Spin up a DHCP/TFTP server on that VM.  Then create another guest in virt-manager by selecting Network Boot(PXE) as the install source.  When selecting the virtual network with a PXE server a warning message will be displayed saying the Network doesn't support PXE booting (though the install will complete just fine)

Additional info:
Looks current logic for can_pxe() on Network objects is to say the network supports PXE if network forwards traffic but is non-natted, or if there's a bootp file specified on the network (but this requires DHCP enabled on the network, and is not feasible for cases where PXE guest also provides DHCP).  May be best to just change the warning message instead
Comment 1 Cole Robinson 2020-01-26 19:34:09 UTC 
Thanks for the report. The PXE warning was removed upstream from virt-manager. For virt-install I changed the text like you suggested

commit d0d672e6d57df54af3d5d15c3078237a6d59bf2b (HEAD -> master)
Author: Cole Robinson <crobinso>
Date:   Sun Jan 26 14:03:51 2020 -0500

    virt-install: Change PXE warning to be less authoritative
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1693891