Bug 1693994

Summary: [RFE][V2V][UI] Migration plan detail popover don't show conversion host if related conversion host gets deleted
Product: Red Hat CloudForms Management Engine Reporter: Yadnyawalk Tale <ytale>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED ERRATA QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.2CC: bthurber, mturley, simaishi, smallamp, sshveta
Target Milestone: GAKeywords: RFE
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.11.0.18 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:36:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On: 1738643    
Bug Blocks:    
Attachments:
Description Flags
no_conversion_host.png none

Description Yadnyawalk Tale 2019-03-29 08:54:38 UTC
Created attachment 1549362 [details]
no_conversion_host.png

Description of problem:
Migration plan detail popover don't show conversion host if related conversion host gets deleted 


Version-Release number of selected component (if applicable):
5.10.2.2.20190319204241_4304a7d


How reproducible:
100%


Steps to Reproduce:
1. Migrate vm on conversion host
2. Check conversion host from popover of plan detail page
3. Delete conversion host entry
4. Check popover again


Actual results:
You will see conversion host is gone from popover after deletion


Expected results:
Should have record of related conversion host of plan to debug after deletion.
 

Additional info:
Saw behavior with RHV, pretty sure it should also with OSP too but did not checked yet.

Comment 2 Fabien Dupont 2019-03-29 09:13:41 UTC
Not sure it's a bug. If you delete the conversion host, don't expect to do a complete debug as part of the information will also have been deleted.

To me, it's at best a RFE.

Comment 3 Yadnyawalk Tale 2019-03-29 09:17:54 UTC
Agree though. Converting it to RFE.

Comment 4 Fabien Dupont 2019-07-30 08:21:19 UTC
Store the conversion host name in the task options - https://github.com/ManageIQ/manageiq/pull/19075

Comment 5 CFME Bot 2019-07-30 22:20:44 UTC
New commit detected on ManageIQ/manageiq/ivanchuk:

https://github.com/ManageIQ/manageiq/commit/8225bd67ba20fe1681d56f5078e7c2033ce4e776
commit 8225bd67ba20fe1681d56f5078e7c2033ce4e776
Author:     Brandon Dunne <bdunne>
AuthorDate: Tue Jul 30 10:13:11 2019 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Jul 30 10:13:11 2019 -0400

    Merge pull request #19075 from fdupont-redhat/v2v_store_conversion_host_name_in_task

    [V2V] Store the conversion host name in the task options

    (cherry picked from commit 3ab6505abb78ab9f201569617695b2d52df6ff32)

    https://bugzilla.redhat.com/show_bug.cgi?id=1693994

 lib/infra_conversion_throttler.rb | 3 +-
 spec/lib/infra_conversion_throttler_spec.rb | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Comment 6 Fabien Dupont 2019-07-31 06:25:03 UTC
@mike, the above PR stores the conversion host in the task options hash: task.options.conversion_host_name.
Could you please update the UI code to use it ? I think it's a pretty simple change, so I'd like to have it in 5.11.0. Unless, you tell me it's too complex or you're heap overflowed ;)

Comment 7 Mike Turley 2019-07-31 16:56:10 UTC
Sure Fabien, that's a simple change. I'll put it next on my list and I'll let you know when it's done.

Comment 9 CFME Bot 2019-08-05 15:38:13 UTC
New commit detected on ManageIQ/manageiq-v2v/ivanchuk:

https://github.com/ManageIQ/manageiq-v2v/commit/1df94caea6513bc133046aef390f176241bb7637
commit 1df94caea6513bc133046aef390f176241bb7637
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Mon Aug  5 06:32:31 2019 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Mon Aug  5 06:32:31 2019 -0400

    Merge pull request #1015 from mturley/1014-fix-conversion-host-name

    [#1014][BZ#1693994] Fix conversion host name not appearing on plan details after conversion host is deleted

    (cherry picked from commit f59328922e846f9dfc9192ccb973457ac364f890)

    https://bugzilla.redhat.com/show_bug.cgi?id=1693994

 app/javascript/react/screens/App/Plan/components/PlanRequestDetailList/PlanRequestDetailList.js | 7 +-
 1 file changed, 5 insertions(+), 2 deletions(-)

Comment 10 Shveta 2019-08-19 20:15:48 UTC
Conversion host is shown even when it is deleted .
Verified in 5.11.0.19.20190813184334_ed72c9f

Comment 12 errata-xmlrpc 2019-12-12 13:36:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199