Bug 1694267

Hi Bernhard,

we generally handle patches on the libguestfs mailing list -- see:
http://libguestfs.org/guestfs-hacking.1.html#submitting-patches
I recommend you to send the patch there, so we can properly review it.

A first review follows, so we can avoid one patch roundtrip:

1) it looks like the the mageia package_handler should work fine also on OpenMandriva, except for the distro identification; we generally do not create new package handlers just for a different distro without any other change (e.g. a different package manager/downloader). What about the following (untested) change instead?

diff --git a/src/ph_rpm.ml b/src/ph_rpm.ml
index 46b7f1f..f5715f1 100644
--- a/src/ph_rpm.ml
+++ b/src/ph_rpm.ml
@@ -47,7 +47,7 @@ let opensuse_detect () =
 let mageia_detect () =
   Config.rpm <> "no" && Config.rpm2cpio <> "no" && rpm_is_available () &&
     ((Config.urpmi <> "no" && Config.fakeroot <> "no") || Config.dnf <> "no") &&
-    (Os_release.get_id () = "mageia" ||
+    (List.mem (Os_release.get_id ()) [ "mageia"; "openmandriva" ] ||
      try (stat "/etc/mageia-release").st_kind = S_REG with Unix_error _ -> false)
 
 let ibm_powerkvm_detect () =

2) in test-harder.sh, there is no need to set distro=openmandriva, as it is a no-op (it is already "openmageia" from ID in os-release)

3) in test-harder.sh, I guess rpm is a package with a non-zero epoch instead of tar? If so, please mention it as comment (as done in the "mageia", and "redhat" cases)

Thanks!

Thanks - pushed upstream in commit bca633bfd14aeeb8ae1331d468db75d1ef31f9ff.

So I pushed this upstream before reading Pino's remark above.  Please try what Pino suggested
in command 1 and if that works we can revert the change and try his fix instead.