Bug 1694712

Summary: Can't compare VMs selected in the genealogy tree
Product: Red Hat CloudForms Management Engine Reporter: Dávid Halász <dhalasz>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Sudhir Mallamprabhakara <smallamp>
Severity: low Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: low    
Version: 5.10.2CC: bmidwood, dmetzger, hkataria, lavenel, mhradil, mpovolny, mshriver, obarenbo
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1702066 (view as bug list) Environment:
Last Closed: 2019-12-13 14:58:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1702066    

Description Dávid Halász 2019-04-01 12:45:08 UTC 
Description of problem:
When trying to check the checkboxes related for VMs in a genealogy tree, the compare button does not get enabled.

Version-Release number of selected component (if applicable):
5.10.2.2.20190319204241_4304a7d

How reproducible:


Steps to Reproduce:
1. Have at least one provider with some VMs
2. Set the parent-child relationship for at least two VMs
3. Open one of the VM's genealogy screen from its summary
4. Check at least two checkboxes in the genealogy tree

Actual results:
The compare button in the toolbar stays disabled

Expected results:
The compare button in the toolbar should be enabled

Additional info:
MartinH already volunteered for making a fix
Comment 3 CFME Bot 2019-04-04 09:17:19 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b063791e41cd02b1d30d2cfc30e81108d0bf07f3
commit b063791e41cd02b1d30d2cfc30e81108d0bf07f3
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Apr  1 08:38:37 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Apr  1 08:38:37 2019 -0400

    miqSetToolbarCount - fix setting toolbar counts

    miqSetButtons is not only called for toolbars, but also fake toolbars,
    so, we can't always update the toolbar count when nonzero.

    But for specific cases we can - so splitting the functionality into miqSetToolbarCount,
    which will always set the count for toolbars.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694712

 app/assets/javascripts/miq_application.js | 13 +-
 app/assets/javascripts/miq_tree.js | 6 +-
 2 files changed, 11 insertions(+), 8 deletions(-)
Comment 5 Antonin Pagac 2019-04-29 07:48:09 UTC 
Verified with 5.11.0.1.