Bug 1694912

Summary: NetworkManager Keyfile Plugin Failed to Add Settings
Product: [Fedora] Fedora Reporter: Yupeng Chang <changyp6>
Component: NetworkManagerAssignee: Lubomir Rintel <lkundrak>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: bgalvani, dcbw, fgiudici, gnome-sig, john.j5live, lkundrak, mclasen, rhughes, rstrode, sandmann
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-02 09:43:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch file to fix this issue in NetworkManager 1.16.0 none

Description Yupeng Chang 2019-04-02 03:34:49 UTC 
Created attachment 1550865 [details]
Patch file to fix this issue in NetworkManager 1.16.0

Description of problem:
Since NetworkManager 1.14.x, keyfile plugin cannot work properly.

When you set a network device in /etc/network/interface, NetworkManager still use DHCP to obtain the IP address.

Version-Release number of selected component (if applicable):

1.14.x ~ 1.16.0

How reproducible:

set eth0 to static in /etc/network/interface

Actual results:

NetworkManager reports "nm-settings.c xxx: assertion 'failed' "

Expected results:

NetworkManager can set IP address correctly

Additional info:

I have already addressed the bug, it is a typo in file 
src/settings/plugins/ifupdown/nms-ifupdown-plugin.c

And I have already submitted the bug report and patch file at NetworkManager's bug tracker, following is the URL
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/145

However, it seems that no one cares about this bug.
So I try to submit this bug at Fedora bugzilla. Please someone push the NetworkManager team to fix this ugly typo.

Attached is the patch for NetworkManager 1.16.0
Comment 1 Beniamino Galvani 2019-04-02 09:43:55 UTC 
Thanks, patch applied to master:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/1dd67583e3eecba09ee983ef6a443ded64303846

and nm-1-16 branch.