Bug 1695209

Summary:	autoscaler operator does not reset progressing transition timestamp when it upgrades
Product:	OpenShift Container Platform	Reporter:	Clayton Coleman <ccoleman>
Component:	Cloud Compute	Assignee:	Brad Ison <brad.ison>
Status:	CLOSED ERRATA	QA Contact:	Jianwei Hou <jhou>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.1.0	CC:	agarcial, brad.ison, jhou, wsun, zhsun
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-04 10:46:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1697814
Bug Blocks:

Description Clayton Coleman 2019-04-02 16:22:19 UTC

During an upgrade, operators are required to update the lastTransitionTimestamp of Progressing when they start upgrading and when they complete.  If there is no need to set progressing, the last transition time should still be reset at the end of an upgrade when they hit "level".

When I started an upgrade (39m ago was the beginning) I see:

clusteroperator.config.openshift.io/cluster-autoscaler                   0.0.1     True        False         False     64m

which means the operator did not reset progressing lastTransitionTime

This value is used to tell the admin when "something happened" and an upgrade is "something".

Comment 1 Clayton Coleman 2019-04-02 17:36:28 UTC

https://github.com/openshift/cluster-version-operator/pull/154 will document this and an e2e test will verify it in the future post-upgrade

Comment 2 Brad Ison 2019-04-04 13:03:34 UTC

I think this should fix this:
https://github.com/openshift/cluster-autoscaler-operator/pull/84

It would be useful to know where this output came from though:

clusteroperator.config.openshift.io/cluster-autoscaler                   0.0.1     True        False         False     64m


The "Since" printer column for the CRD uses the timestamp from available, not progressing, which was confusing.

Comment 4 Wei Sun 2019-04-10 03:36:08 UTC

Please check if it could be verified.

Comment 5 sunzhaohua 2019-04-11 06:29:50 UTC

Verified.

Upgrade from 4.0.0-0.nightly-2019-04-10-141956 to 4.0.0-0.nightly-2019-04-10-182914

Before upgrade:
$ oc get clusteroperator cluster-autoscaler -o yaml
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: 2019-04-11T02:31:41Z
  generation: 1
  name: cluster-autoscaler
  resourceVersion: "2122"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/cluster-autoscaler
  uid: f0c89a58-5c01-11e9-a622-02a87c79c5de
spec: {}
status:
  conditions:
  - lastTransitionTime: 2019-04-11T02:31:41Z
    message: at version 4.0.0-0.nightly-2019-04-10-141956
    status: "True"
    type: Available
  - lastTransitionTime: 2019-04-11T02:31:56Z
    status: "False"
    type: Progressing
  - lastTransitionTime: 2019-04-11T02:31:56Z
    status: "False"
    type: Failing
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-machine-api
    resource: namespaces
  versions:
  - name: operator
    version: 4.0.0-0.nightly-2019-04-10-141956

After upgrade:
$ oc get clusteroperator cluster-autoscaler -o yaml 
apiVersion: config.openshift.io/v1
kind: ClusterOperator
metadata:
  creationTimestamp: 2019-04-11T02:31:41Z
  generation: 1
  name: cluster-autoscaler
  resourceVersion: "61044"
  selfLink: /apis/config.openshift.io/v1/clusteroperators/cluster-autoscaler
  uid: f0c89a58-5c01-11e9-a622-02a87c79c5de
spec: {}
status:
  conditions:
  - lastTransitionTime: 2019-04-11T02:31:41Z
    message: at version 4.0.0-0.nightly-2019-04-10-182914
    status: "True"
    type: Available
  - lastTransitionTime: 2019-04-11T04:05:15Z
    status: "False"
    type: Progressing
  - lastTransitionTime: 2019-04-11T02:31:56Z
    status: "False"
    type: Failing
  extension: null
  relatedObjects:
  - group: ""
    name: openshift-machine-api
    resource: namespaces
  versions:
  - name: operator
    version: 4.0.0-0.nightly-2019-04-10-182914

Comment 7 errata-xmlrpc 2019-06-04 10:46:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758