Bug 1695566

Summary: Updating Advanced Settings with an invalid key-value pair lands in Exception page
Product: Red Hat CloudForms Management Engine Reporter: Parthvi Vala <pvala>
Component: APIAssignee: Yuri Rudman <yrudman>
Status: CLOSED ERRATA QA Contact: Parthvi Vala <pvala>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.0CC: dmetzger, obarenbo, simaishi, yrudman
Target Milestone: GA   
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-12 13:36:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Exception Page none

Description Parthvi Vala 2019-04-03 11:31:14 UTC
Created attachment 1551337 [details]
Exception Page

Description of problem:
While automating test case for a BZ, I passed wrong data for updating the advanced settings and landed in Exception page on navigating to `Configuration`.

Version-Release number of selected component (if applicable):
5.10

How reproducible:
Always

Steps to Reproduce:
1. Send a request:
       PATCH /api/servers/:server_id/settings
       JSON: {"allow_api_service_ordering": false }
2. Login to appliance, navigate to `Configuration`. If everything is normal, logout and login again.
3. Navigate to `Configuration`.

Actual results:
The page shows Exception.

Expected results:
Not sure what expected result must be in this case.

Additional info:
Problems exists from 5.9.

Comment 5 CFME Bot 2019-04-05 08:52:19 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/de010a99402cefbb3b0c0e55c1e1aaa54080ff88
commit de010a99402cefbb3b0c0e55c1e1aaa54080ff88
Author:     Yuri Rudman <yrudman>
AuthorDate: Thu Apr  4 08:54:13 2019 -0400
Commit:     Yuri Rudman <yrudman>
CommitDate: Thu Apr  4 08:54:13 2019 -0400

    fix: when settings value added on root level (without category) than parameter 'hashin' passed to copy_hash(hashin) is not instanse of Hash and error raised [NoMethodError] undefined method 'deep_clone'...
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1695566

 app/controllers/ops_controller/settings/common.rb | 4 +-
 1 file changed, 1 insertion(+), 3 deletions(-)

Comment 6 Parthvi Vala 2019-05-01 07:23:02 UTC
FIXED. Verified on 5.11.0.2.20190430174828_0e34dea.

Comment 8 errata-xmlrpc 2019-12-12 13:36:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:4199