Bug 169604
| Summary: | Review Request: dclib - Direct Connect file sharing library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
| Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list, gajownik, pfrields |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://dcgui.berlios.de | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-10-03 16:02:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 169605 | ||
|
Description
Luke Macken
2005-09-30 06:43:09 UTC
This is already a part of the Livna repository. I can't remember what the rationale was for not adding it to Extras, but I'll see if I can Google an answer for that later today. Needs work:
* The package should contain the text of the license, in the COPYING and
COPYING.OpenSSL files (wiki: PackageReviewGuidelines)
* Each %files section should have a %defattr line (for -devel package)
(wiki: PackageReviewGuidelines)
* Requires for -devel is wrong, it should be : %{name} = %{version}
* Please include the usual documentation files (README, AUTHORS, ChangeLog, NEWS,
TODO)
I'd like to know if P2P software is OK for Fedora. Can somebody contact the
legal dpt ?
Wow, stupid mistakes.. I blame lack of sleep :(
These should be fixed. (made Requires: %{name} = %{version}-%{release} to remain
consistent with previous packages (if this is wrong, then I can change it))
http://people.redhat.com/lmacken/dclib-0.3.7-2.src.rpm
http://people.redhat.com/lmacken/dclib.spec
Looks like P2P software is OK: https://www.redhat.com/archives/fedora-extras-list/2005-September/msg01573.html Review for release 2: * RPM name is OK * Source dclib-0.3.7.tar.gz is the same as upstream * Builds fine in mock * rpmlint of dclib looks OK * rpmlint of dclib-devel looks OK * File list of dclib looks OK * File list of dclib-devel looks OK * Works fine (tested with valknut) Imported into CVS, updated owners.list file, requested FC-3 and FC-4 CVS branches, and built for devel. Thanks! dclib-devel should probably have "Requires: libxml2-devel", see /usr/include/dclib/cconfig.h (In reply to comment #6) > dclib-devel should probably have "Requires: libxml2-devel", > see /usr/include/dclib/cconfig.h fixed, thanks. (In reply to comment #7) > fixed, thanks. Not quite, it should be in dclib-devel, not dclib... Oops, my bad. Fixed. |