Bug 169605
Summary: | Review Request: valknut - A Direct Connect client | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Luke Macken <lmacken> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list, pfrields |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://dcgui.berlios.de | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2005-10-04 21:41:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 169604 | ||
Bug Blocks: | 163779 |
Description
Luke Macken
2005-09-30 06:44:42 UTC
This is also in the Livna repository, but seems not to have been rebuilt for FC4. * BuildRequires: desktop-file-utils is missing * You could replace "--with-qt-dir" with QT environment variable, so you don't have to update it when QT4 is out. Usually, it's: unset QTDIR && . %{_sysconfdir}/profile.d/qt.sh and then %configure * Please use install -p to preserve timestamps * desktop file already contains X-Fedora (In reply to comment #2) > * BuildRequires: desktop-file-utils is missing > * You could replace "--with-qt-dir" with QT environment variable, so you don't > have to update it when QT4 is out. Usually, it's: > unset QTDIR && . %{_sysconfdir}/profile.d/qt.sh > and then %configure > * Please use install -p to preserve timestamps > * desktop file already contains X-Fedora Fixed. http://people.redhat.com/lmacken/valknut.spec http://people.redhat.com/lmacken/valknut-0.3.7-2.src.rpm Missing BuildRequires : libxml-devel (build fails in mock) This was an issue with dclib-devel not pulling down libxml2-devel, which should be fixed now. I also added bzip2-devel to BuildRequires for valknut.. builds fine in mock now. http://people.redhat.com/lmacken/valknut.spec http://people.redhat.com/lmacken/valknut-0.3.7-3.src.rpm Missing BuildRequires: openssl-devel Curiously, it builds without it, but segfaults on startup. (In reply to comment #6) > Missing BuildRequires: openssl-devel > Curiously, it builds without it, but segfaults on startup. Added. http://people.redhat.com/lmacken/valknut-0.3.7-3.src.rpm ermm.. wrong url.. http://people.redhat.com/lmacken/valknut-0.3.7-4.src.rpm Review for release 4: * RPM name is OK * Source valknut-0.3.7.tar.gz is the same as upstream * Builds fine in mock * rpmlint of valknut looks OK * File list of valknut looks OK * Works as expected APPROVED Imported into CVS, added to owners.list, requested branches for FC-3/FC-4, and built for devel. Thanks! |