Bug 1696199

Summary:	dmenu crashes in XmbLookupString()
Product:	[Fedora] Fedora	Reporter:	Filip Andres <filip>
Component:	dmenu	Assignee:	Frantisek Sumsal <frantisek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	29	CC:	bbrryyaann, fedora, gonulce.s, i, lupinix.fedora, nuget, phawkins, ppisar, psabata, samuel.rakitnican
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	dmenu-4.9-3.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-09-14 01:12:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Filip Andres 2019-04-04 10:27:44 UTC

Description of problem:
dmenu doesn't check the return value of the XOpenIM call and uses the return value when calling XCreateIC (inside of which it's attempted to be dereferenced).

Version-Release number of selected component (if applicable):
Fedora 29 (but probably others too)

How reproducible:
Always, by running dmenu

Steps to Reproduce:
1. run dmenu
2. when the menu appears push any button 

Actual results:
Crash

Expected results:


Additional info:
Upstream fixed the error in commits:
https://git.suckless.org/dmenu/commit/f5036b90efd9423d805923a0bc73cd54e30e72ab.html
https://git.suckless.org/dmenu/commit/a9b1de384ae1ad30805e893af5cd6ea9b87c89da.html
https://git.suckless.org/dmenu/commit/db6093f6ec1bb884f7540f2512935b5254750b30.html

The commits were published after packaging took place in fedora and upstream didn't publish a new version but updated the source tarball.

Comment 1 srakitnican 2019-05-08 20:57:45 UTC

Backtrace: bug 1697003.

Comment 2 Petr Pisar 2019-05-09 07:04:59 UTC

*** Bug 1689359 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Update System 2019-09-05 14:17:28 UTC

FEDORA-2019-177307aa1e has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-177307aa1e

Comment 4 Fedora Update System 2019-09-06 12:11:14 UTC

dmenu-4.9-3.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-177307aa1e

Comment 5 Fedora Update System 2019-09-14 01:12:26 UTC

dmenu-4.9-3.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.