Bug 1696250

When I build the package and try to install it it fails to install because of the backports-functools dep failing.
Error:
 Problem: conflicting requests
  - nothing provides python3.7dist(backports.functools-lru-cache) needed by python-cheroot-6.5.4-1.fc31.noarch 

The dep backports-functools is a py2-dep-only so I've removed it from the spec.
It's listed in the egg-info in the source as well but that egg-info dir is removed in %prep

Trying to figure out why there's still a dep on it.

Got it fixed, new spec and srpm uploaded.

 - Please consider using %{py3_dist} macro for you dependencies. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_requires_and_buildrequires_with_standardized_names

 - Send bug report for these and document it in the spec:

# two tests that fail and unsure why. Marked skipped for now.
sed -i '854i.skip(reason="Skip test_598 - Not sure why this fails :/")' cheroot/test/test_conn.py
sed -i '730i.skip(reason="Skip test_Chunked_Encoding - Not sure why this fails :/")' cheroot/test/test_conn.py
# 1 ssl test fail
sed -i '187i.skip(reason="Skip test_tls_client_auth - Type Error :/")' cheroot/test/test_ssl.py

- Source0:        https://files.pythonhosted.org/packages/source/c/%{pypi_name}/%{pypi_name}-%{version}.tar.gz → %{pypi_source}

 - Why are docs disabled?

%global with_docs 0

 - use %bcond_with/%bcond_without for your conditionals

 - you need to make a python3 subpackage!

New spec and srpm uploaded.
added python3dist()
got two of the tests working.
posted link to bug report for ssl test failing
updated source
added comment for docs and fixed conditionals
subpackage added

%description -n python3-%{pypi_name}
%{description}

 This won't work. If you want to reuse the description make a %global containing it.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
     License". 61 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/python-cheroot/review-
     python-cheroot/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
     Note: Macros in: python3-cheroot (description)
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-cheroot-6.5.4-1.fc31.noarch.rpm
          python-cheroot-6.5.4-1.fc31.src.rpm
python3-cheroot.noarch: W: unexpanded-macro %description -l C %{description}
python3-cheroot.noarch: W: no-manual-page-for-binary cheroot
python-cheroot.src: W: spelling-error %description -l en_US pytest -> testes
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

description fix. spec and srpm reuploaded

Package approved.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cheroot

Note that you shouldn't need to BR pytest-testmon to build and test a package. I suppose upstream uses it, but I see no need for such dependency in RPM build.

That said, it might be easier to just BR it instead of patching/sedding it out.

Thx for the info @Miro

Sry, got bugzilla happy and closed this one prematurely.

Oops, actually read my email wrong, this is closed rawhide... sry for the confusion