Bug 1696362

Summary: Different syntax by Service Request in Master region
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: Tina Fitzgerald <tfitzger>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: urgent Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.9.9CC: abellott, bjarolim, dmetzger, gmccullo, gtanzill, jrafanie, mkanoor, mshriver, obarenbo, rchincho, rspagnol, tfitzger, tuado, vaclavbortlik
Target Milestone: GAKeywords: ZStream
Target Release: 5.10.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.3.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1694716 Environment:
Last Closed: 2019-04-23 07:46:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1694716    
Bug Blocks:    

Comment 2 CFME Bot 2019-04-04 16:04:15 UTC 
New commit detected on ManageIQ/manageiq-api/hammer:

https://github.com/ManageIQ/manageiq-api/commit/3e9150d0c9d6629a2662d926c96a5142a664d36c
commit 3e9150d0c9d6629a2662d926c96a5142a664d36c
Author:     Alberto Bellotti <abellotti.github.com>
AuthorDate: Thu Apr  4 09:39:53 2019 -0400
Commit:     Alberto Bellotti <abellotti.github.com>
CommitDate: Thu Apr  4 09:39:53 2019 -0400

    Merge pull request #572 from gtanzillo/dialog-indifferent-access

    Added logic to support both string and symbol access to keys in dialog hash under options

    (cherry picked from commit 023da5f3789cd6a30eea4d8cb409795d53c9da23)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696362

 lib/services/api/request_parser.rb | 6 +-
 spec/lib/services/api/request_parser_spec.rb | 8 +
 2 files changed, 13 insertions(+), 1 deletion(-)
Comment 4 Greg McCullough 2019-04-12 14:37:20 UTC 
Niyaz - Yes, that does look correct.

It would be great if we could do a slightly deeper check as the related fix changes the hash to be from the class HashWithIndifferentAccess.

If you could, from the rails console run the following line:
  ServiceTemplateProvisionTask.find(2).options[:dialog].class

I would expect it to return "ActiveSupport::HashWithIndifferentAccess"

Instead of the old class type of "Hash"

This would ensure that a caller could access the data with either symbols or strings.
Comment 7 errata-xmlrpc 2019-04-23 07:46:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0796