Bug 1696423
| Summary: | [v2v] [RFE] Hidden UI changes to support Conversion Hosts settings page | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> |
| Component: | V2V | Assignee: | Fabien Dupont <fdupont> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shveta <sshveta> |
| Severity: | medium | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | medium | ||
| Version: | 5.10.2 | CC: | bthurber, fdupont, jprause |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream |
| Target Release: | 5.10.3 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | V2V | ||
| Fixed In Version: | 5.10.3.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1693339 | Environment: | |
| Last Closed: | 2019-04-30 20:32:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | V2V | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1693339 | ||
| Bug Blocks: | |||
|
Comment 2
CFME Bot
2019-04-05 00:13:30 UTC
New commit detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/19084c8d3c1334d7bb83ea5b43263cb15b33d186 commit 19084c8d3c1334d7bb83ea5b43263cb15b33d186 Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Feb 12 10:43:34 2019 -0500 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Feb 12 10:43:34 2019 -0500 Merge pull request #876 from mturley/conv-host-wizard-step2 Conversion Host Configuration Wizard - Step #2 - Host(s) (cherry picked from commit e64122f30b4a92d36d9bddf297674d5036583674) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/assets/stylesheets/manageiq-v2v/base.scss | 3 +- app/assets/stylesheets/manageiq-v2v/type-ahead-select.scss | 58 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardHostsStep/ConversionHostWizardHostsStep.js | 55 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardHostsStep/index.js | 21 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardLocationStep/ConversionHostWizardLocationStep.js | 67 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardLocationStep/index.js | 20 +- app/javascript/react/screens/App/common/forms/TypeAheadSelectField.js | 18 + app/javascript/redux/common/targetResources/targetResourcesConstants.js | 2 +- 8 files changed, 190 insertions(+), 54 deletions(-) New commits detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/fcfef595e41bee8cee8db9dc993821900905ee28 commit fcfef595e41bee8cee8db9dc993821900905ee28 Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Mon Mar 4 11:58:19 2019 -0500 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Mon Mar 4 11:58:19 2019 -0500 Merge pull request #882 from mzazrivec/conversion_hosts_list_view_phase_2 Conversion Host: list view phase 2 (cherry picked from commit 1daec12682ad9885a71aadf88193a2e81d7c0c7e) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/SettingsActions.js | 36 +- app/javascript/react/screens/App/Settings/SettingsConstants.js | 4 + app/javascript/react/screens/App/Settings/SettingsReducer.js | 61 +- app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsReducer.test.js.snap | 60 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettings.js | 34 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostRemoveButton.js | 26 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js | 121 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/DeleteConversionHostConfirmationModal.js | 66 + 8 files changed, 355 insertions(+), 53 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/e2c0d2098c557459814f4a9d448402066ce99457 commit e2c0d2098c557459814f4a9d448402066ce99457 Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Tue Mar 5 13:35:16 2019 -0500 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Tue Mar 5 13:35:16 2019 -0500 Merge pull request #894 from mturley/conv-host-wizard-cloud-user Conversion Host Configuration Wizard - use correct default cloud-user (with a dash) instead of cloud_user (cherry picked from commit 36a087ebf61c32937fbe5378ba087fcdb2f5beba) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardAuthenticationStep/ConversionHostWizardAuthenticationStep.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://github.com/ManageIQ/manageiq-v2v/commit/4f06604d6511d4fe36cf6668e11b14c4e33ae3ec commit 4f06604d6511d4fe36cf6668e11b14c4e33ae3ec Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Mar 12 07:36:01 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Mar 12 07:36:01 2019 -0400 Merge pull request #889 from mturley/conv-host-tasks-polling Conversion Host Configuration - List view #3 - Polling for tasks and rendering enable/disable status (cherry picked from commit d4ea6f601f4e6b8af24e6e997e626d92b4d0b616) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/Settings.js | 2 +- app/javascript/react/screens/App/Settings/Settings.scss | 9 + app/javascript/react/screens/App/Settings/SettingsActions.js | 12 + app/javascript/react/screens/App/Settings/SettingsConstants.js | 1 + app/javascript/react/screens/App/Settings/SettingsReducer.js | 63 +- app/javascript/react/screens/App/Settings/__tests__/SettingsReducer.test.js | 6 +- app/javascript/react/screens/App/Settings/__tests__/__snapshots__/Settings.test.js.snap | 1 + app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsReducer.test.js.snap | 132 +- app/javascript/react/screens/App/Settings/helpers.js | 77 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettings.js | 82 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettingsConstants.js | 10 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/__tests__/ConversionHostsSettings.test.js | 20 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostRemoveButton.js | 3 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardHostsStep/ConversionHostWizardHostsStep.js | 26 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardHostsStep/index.js | 10 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js | 64 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 126 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/DeleteConversionHostConfirmationModal.js | 31 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/index.js | 54 +- 19 files changed, 583 insertions(+), 146 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/d474c1ce19d48bf6c7e4fdf5a1cd257b6780e43b commit d474c1ce19d48bf6c7e4fdf5a1cd257b6780e43b Author: Milan Zázrivec <mzazrivec> AuthorDate: Thu Mar 14 05:30:56 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Thu Mar 14 05:30:56 2019 -0400 Merge pull request #907 from mturley/conv-host-tasks-meta-fix Conversion Host Settings page: Ensure task.meta will always be defined (cherry picked from commit dc8eb8ba5c87b14b1284d9c66d6efe827f09edef) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://github.com/ManageIQ/manageiq-v2v/commit/0951eb76f87d1ac17ef7429c14c08ac59de946a5 commit 0951eb76f87d1ac17ef7429c14c08ac59de946a5 Author: Milan Zázrivec <mzazrivec> AuthorDate: Thu Mar 14 05:45:07 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Thu Mar 14 05:45:07 2019 -0400 Merge pull request #908 from mturley/conv-host-wizard-ssh-keys Conversion Host Configuration Wizard - Properly pass SSH keys and VDDK path to API (cherry picked from commit e65d65ea6dd511b62bae5121ea526f0077f4e368) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardAuthenticationStep/ConversionHostWizardAuthenticationStep.js | 4 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardResultsStep/helpers.js | 12 +- 2 files changed, 7 insertions(+), 9 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/adae39a1b02cdd8c4148d514eb70f300d22ca3fe commit adae39a1b02cdd8c4148d514eb70f300d22ca3fe Author: Mike Turley <mike.turley.umass.edu> AuthorDate: Thu Mar 14 11:36:51 2019 -0400 Commit: Mike Turley <mike.turley.umass.edu> CommitDate: Thu Mar 14 11:36:51 2019 -0400 Merge pull request #909 from mzazrivec/fix_conversion_host_removal_modal Fix conversion host removal modal (cherry picked from commit fda0a672389ad4280ba9b07be511b74736e1a253) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/DeleteConversionHostConfirmationModal.js | 12 +- 1 file changed, 8 insertions(+), 4 deletions(-) New commits detected on ManageIQ/manageiq-v2v/hammer: https://github.com/ManageIQ/manageiq-v2v/commit/b8f39b73264982abffe87faeaf6ff461bc3453cc commit b8f39b73264982abffe87faeaf6ff461bc3453cc Author: Milan Zázrivec <mzazrivec> AuthorDate: Wed Mar 20 04:56:56 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Wed Mar 20 04:56:56 2019 -0400 Merge pull request #913 from mturley/conv-host-wizard-ssh-field-name Conversion Host Configuration Wizard - rename API field from ssh_key to conversion_host_ssh_private_key (cherry picked from commit 3e28cca810f0b6cae0164249bea0a218f93f9d0e) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardResultsStep/helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) https://github.com/ManageIQ/manageiq-v2v/commit/e5b7742b2506071b8b902e3c8320fd6c596c5d6c commit e5b7742b2506071b8b902e3c8320fd6c596c5d6c Author: Milan Zázrivec <mzazrivec> AuthorDate: Tue Mar 26 12:53:41 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Tue Mar 26 12:53:41 2019 -0400 Merge pull request #916 from mturley/901-conv-host-retry [#901] Conversion Host Enablement - List View - Add Retry button with modal for re-entering SSH keys (cherry picked from commit 4d7e37cea2aaf83cc5ce8a230c1f556e9b33134f) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/common/constants.js | 5 + app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepConstants.js | 5 - app/javascript/react/screens/App/Mappings/screens/MappingWizard/components/MappingWizardClustersStep/MappingWizardClustersStepSelectors.js | 2 +- app/javascript/react/screens/App/Settings/SettingsActions.js | 23 +- app/javascript/react/screens/App/Settings/SettingsConstants.js | 4 + app/javascript/react/screens/App/Settings/SettingsReducer.js | 18 +- app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsReducer.test.js.snap | 36 + app/javascript/react/screens/App/Settings/helpers.js | 11 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/ConversionHostsSettings.js | 22 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostRetryButton.js | 32 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardAuthenticationStep/ConversionHostWizardAuthenticationStep.js | 47 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsList.js | 21 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostsListItem.js | 37 +- app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/RetryConversionHostConfirmationModal/RetryConversionHostConfirmationModal.js | 117 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/RetryConversionHostConfirmationModal/index.js | 34 + app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/index.js | 14 +- app/javascript/react/screens/App/common/forms/SshKeyField.js | 30 + 17 files changed, 392 insertions(+), 66 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/cdbe65f1155c9c4bead6c302261aeb3987a80d5d commit cdbe65f1155c9c4bead6c302261aeb3987a80d5d Author: Milan Zázrivec <mzazrivec> AuthorDate: Wed Apr 3 05:17:19 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Wed Apr 3 05:17:19 2019 -0400 Merge pull request #924 from mturley/auth-user-root-for-rhv Conversion Host Wizard: set the auth_user to 'root' for RHV hosts (cherry picked from commit 28a3302324d630bfd1420203234e651131c65dde) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/screens/ConversionHostsSettings/components/ConversionHostWizard/ConversionHostWizardResultsStep/helpers.js | 4 +- 1 file changed, 1 insertion(+), 3 deletions(-) https://github.com/ManageIQ/manageiq-v2v/commit/11a670309d45854610682787dccf372b1cff3b42 commit 11a670309d45854610682787dccf372b1cff3b42 Author: Milan Zázrivec <mzazrivec> AuthorDate: Fri Apr 5 04:19:52 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Fri Apr 5 04:19:52 2019 -0400 Merge pull request #928 from mturley/settings-helper-tests Conversion Host Settings - Unit tests for helpers, prevent corner case of reappearing failures (cherry picked from commit f6dfc222053d10d30de268c253176aeea32dabbc) https://bugzilla.redhat.com/show_bug.cgi?id=1696423 app/javascript/react/screens/App/Settings/__tests__/helpers.test.js | 137 + app/javascript/react/screens/App/Settings/helpers.js | 28 +- 2 files changed, 151 insertions(+), 14 deletions(-) Since this PR is to add conversion host page changes but the tab will be hidden until PR https://github.com/ManageIQ/manageiq-v2v/pull/922 gets merged. Nothing to verify in UI yet. Verifying based on above PR's. |