Bug 1696437
| Summary: | ConversionHost model is missing validations | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> |
| Component: | V2V | Assignee: | Fabien Dupont <fdupont> |
| Status: | CLOSED ERRATA | QA Contact: | Yadnyawalk Tale <ytale> |
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | high | ||
| Version: | 5.10.2 | CC: | bthurber, dmetzger, mshriver, sshveta |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.10.4 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 5.10.4.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1695797 | Environment: | |
| Last Closed: | 2019-05-21 05:46:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | V2V | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1695797 | ||
| Bug Blocks: | 1700461 | ||
|
Comment 2
CFME Bot
2019-04-24 19:47:05 UTC
New commits detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/47d0ef9ab752a565f4fb7b67741a0dce909aa834 commit 47d0ef9ab752a565f4fb7b67741a0dce909aa834 Author: Adam Grare <agrare> AuthorDate: Tue Dec 11 14:15:21 2018 -0500 Commit: Adam Grare <agrare> CommitDate: Tue Dec 11 14:15:21 2018 -0500 Merge pull request #18277 from djberg96/conversion_host_validations2 Add ConversionHost validations (cherry picked from commit c6174684c548dc78120ab21ff2725d8f00a70bec) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 app/models/conversion_host.rb | 22 +- spec/models/conversion_host_spec.rb | 10 +- spec/models/service_template_transformation_plan_task_spec.rb | 2 +- 3 files changed, 23 insertions(+), 11 deletions(-) https://github.com/ManageIQ/manageiq/commit/376bc43b6badf0006f13b74b7cd1f0c6af17ee65 commit 376bc43b6badf0006f13b74b7cd1f0c6af17ee65 Author: Adam Grare <agrare> AuthorDate: Mon Feb 11 10:43:25 2019 -0500 Commit: Adam Grare <agrare> CommitDate: Mon Feb 11 10:43:25 2019 -0500 Merge pull request #18434 from djberg96/conversion_host_resource_type_validation Change ConversionHost resource_type validation (cherry picked from commit 6ecc88399feb70a837684dd047aea08e33b48709) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 app/models/conversion_host.rb | 16 +- spec/models/conversion_host/configurations_spec.rb | 4 +- spec/models/conversion_host_spec.rb | 30 +- spec/models/service_template_transformation_plan_request_spec.rb | 6 +- spec/models/service_template_transformation_plan_task_spec.rb | 10 +- 5 files changed, 49 insertions(+), 17 deletions(-) New commits detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/564d170024abf429bfd394f5fa9c61572de1c5ed commit 564d170024abf429bfd394f5fa9c61572de1c5ed Author: Adam Grare <agrare> AuthorDate: Wed Jan 23 11:19:02 2019 -0500 Commit: Adam Grare <agrare> CommitDate: Wed Jan 23 11:19:02 2019 -0500 Merge pull request #18381 from djberg96/conversion_host_validations_fix Fix address validation for ConversionHost model (cherry picked from commit 45d836b9a62836781bce7af50f5cb059b934b1d5) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 app/models/conversion_host.rb | 4 +- spec/models/conversion_host_spec.rb | 29 + 2 files changed, 31 insertions(+), 2 deletions(-) https://github.com/ManageIQ/manageiq/commit/0c99f2223eb9b5020ac448f4fa80290c2d3d9d89 commit 0c99f2223eb9b5020ac448f4fa80290c2d3d9d89 Author: Adam Grare <agrare> AuthorDate: Thu Apr 4 15:57:05 2019 -0400 Commit: Adam Grare <agrare> CommitDate: Thu Apr 4 15:57:05 2019 -0400 Merge pull request #18610 from djberg96/conversion_host_address_validation [V2V] Allow the ConversionHost#address field to be empty (cherry picked from commit 81a9ecaa36f2fd707092047716cafe4c217be158) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 app/models/conversion_host.rb | 3 +- spec/models/conversion_host_spec.rb | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) New commit detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/716845cb5a0b57fe9ea29c80f8083657a2a892c9 commit 716845cb5a0b57fe9ea29c80f8083657a2a892c9 Author: Adam Grare <agrare> AuthorDate: Fri Apr 26 08:00:14 2019 -0400 Commit: Adam Grare <agrare> CommitDate: Fri Apr 26 08:00:14 2019 -0400 Merge pull request #18690 from djberg96/fix_conversion_host_address_validation [V2V] Fix allowing address to be blank for the ConversionHost model, and update spec. (cherry picked from commit afe8714e54164b619dbd3b8436f9e67b73f3a06f) https://bugzilla.redhat.com/show_bug.cgi?id=1696437 app/models/conversion_host.rb | 2 +- spec/models/conversion_host_spec.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) Fixed in 5.10.4.1.20190430152139_40a1d86. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:1247 |