Bug 1696697

Summary: Unexpected error when viewing request details
Product: Red Hat CloudForms Management Engine Reporter: Ryan Spagnola <rspagnol>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED CURRENTRELEASE QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.9.0CC: bmclaugh, bmidwood, dmetzger, hkataria, kborole, lavenel, mpovolny, mshriver, obarenbo, peli, simaishi, tfitzger, wfitzger
Target Milestone: GAKeywords: Reopened, TestOnly, ZStream
Target Release: 5.11.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.11.0.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1706080 1722545 (view as bug list) Environment:
Last Closed: 2019-12-13 15:09:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1704905, 1706080, 1722545    
Attachments:
Description Flags
test dialog none

Description Ryan Spagnola 2019-04-05 12:49:21 UTC 
Description of problem:
When clicking on a request to view details an unexpected error occurs.

Version-Release number of selected component (if applicable):
5.9.9

How reproducible:


Steps to Reproduce:
1. Go to Services > Requests
2. Click on a request

Actual results:
Unexpected Error

undefined method `[]' for nil:NilClass [miq_request/show]

Expected results:
Request details displayed

Additional info:
Also seen in 5.9.8
Comment 7 William Fitzgerald 2019-04-09 19:51:01 UTC 
Ryan,

When I open up the request in the UI, it is running the dialogs.  The dialogs have an error and this causing the UI to fail.
We believe this issue has been addressed here :

https://bugzilla.redhat.com/show_bug.cgi?id=1667948

Can you test on version 5.9.8.0.20190121201402_b1df4c2 or later ?

Thanks

Billy
Comment 8 Ryan Spagnola 2019-04-09 20:37:47 UTC 
Billy,

The first reproducer is on 5.9.9.


Thanks, 
Ryan
Comment 14 CFME Bot 2019-05-02 20:21:31 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/5526
Comment 15 CFME Bot 2019-05-03 13:36:13 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/c1a6578a20c7d6f9ac088759fdf8d4dea46cfd56
commit c1a6578a20c7d6f9ac088759fdf8d4dea46cfd56
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Thu May  2 16:06:58 2019 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Thu May  2 16:06:58 2019 -0400

    Fix nil:nilClass error by finding Classification by id
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696697

 app/views/miq_request/_request_dialog_details.html.haml | 3 +-
 app/views/miq_request/_st_prov_show.html.haml | 4 +-
 app/views/shared/dialogs/_dialog_field.html.haml | 3 +-
 3 files changed, 6 insertions(+), 4 deletions(-)
Comment 20 Niyaz Akhtar Ansari 2019-05-14 17:46:20 UTC 
Created attachment 1568580 [details]
test dialog
Comment 21 Harpreet Kataria 2019-06-10 14:06:53 UTC 
*** Bug 1697897 has been marked as a duplicate of this bug. ***