Bug 1696846

Summary: vm.remove snapshot does not remove the snapshot from OpenStack
Product: Red Hat CloudForms Management Engine Reporter: Ryan Spagnola <rspagnol>
Component: ProvidersAssignee: Sam Lucidi <slucidi>
Status: CLOSED CURRENTRELEASE QA Contact: Ido Ovadia <iovadia>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.9.0CC: dmetzger, jfrey, jhardy, jprause, maufart, mshriver, obarenbo, simaishi, slucidi, smallamp
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.11.0.10 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1720649 (view as bug list) Environment:
Last Closed: 2019-12-13 15:00:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1704905, 1720649    

Description Ryan Spagnola 2019-04-05 17:55:05 UTC
Description of problem:
The issue is that we take a snapshot of a VM with two disks, which results in two snapshots (one for each disk) in OpenStack. The only code being used to delete the snapshot is the vm.remove_snapshot, which deletes one snapshot but leaves the other snapshot behind. The expectation is that the delete snapshot method would delete everything that the create snapshot method created, however this is not the case.


Version-Release number of selected component (if applicable):
5.9.8.1

How reproducible:
Always

Steps to Reproduce:
1. create a vm in openstack with 2 disks
2. create snapshot (this will create 2 snapshots, 1 for each disk)
3. attempt to delete snapshot using method vm.remove_snapshot

Actual results:
only one snapshot is deleted

Expected results:
both snapshots are deleted

Additional info:
$evm.log(:info, "Deleteing Snapshot with ID = #{$evm.root['dialog_cur_snapshot']}")
vm = $evm.root['vm']
vm.remove_snapshot($evm.root['dialog_cur_snapshot'])
$evm.log(:info, "Snapshot with ID = #{$evm.root['dialog_cur_snapshot']} finished")

Thats the code that we run to delete the snapshot. It's only removing one of the two volumes attached to the instance.

Comment 3 dmetzger 2019-04-08 12:57:34 UTC
Do we know if this behavior is Openstack specific?

Comment 4 dmetzger 2019-04-08 13:43:35 UTC
Incorrect ticket above.

Comment 12 Marek Aufart 2019-06-14 06:02:27 UTC
PR was merged, new manageiq-smartstate gem version released. Main repo uses pessimistic operator for smartstate depencency for both master and hammer branch so updated smartstate should get in with next build.

Comment 14 Ido Ovadia 2019-08-19 13:28:45 UTC
Verified
========
CFME 5.11.0.19