Bug 1697104

Summary: new spec file template contains deprecated tags
Product: [Fedora] Fedora Reporter: Petr Menšík <pemensik>
Component: vimAssignee: Karsten Hopp <karsten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: gchamoul, karsten, zdohnal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vim-8.1.1137-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-13 15:32:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Menšík 2019-04-07 14:37:17 UTC 
Description of problem:
Vim provides new template when asked to edit non-existent spec file.

However, that spec file includes Group tag, which is not recommended. Should not be present for new packages.

Version-Release number of selected component (if applicable):
vim-common-8.1.1099-1.fc29.x86_64

How reproducible:
always

Steps to Reproduce:
1. vim /tmp/new.spec
2.
3.

Actual results:
Contains Group:

Expected results:
Does not contain Group:

Additional info:
Installed template is part of vim-common, path /usr/share/vim/vimfiles/template.spec.

I think comment with link to Packaging guidelines would be useful in new spec files [1] or new package guidelines [2].
Please use Release: 0. After rpmdev-bumpspec it would contain correct changelog format and Release 1.

1. https://docs.fedoraproject.org/en-US/packaging-guidelines
2. https://docs.fedoraproject.org/en-US/quick-docs/creating-rpm-packages/
Comment 1 Zdenek Dohnal 2019-04-08 11:38:06 UTC 
Hi Petr!

Thank you for reporting the issue! It will be issued in next Vim update (arriving in a hour or so).
Comment 2 Fedora Update System 2019-04-08 12:29:54 UTC 
vim-8.1.1137-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3f4706e604
Comment 3 Fedora Update System 2019-04-09 03:13:50 UTC 
vim-8.1.1137-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3f4706e604
Comment 4 Fedora Update System 2019-04-13 15:32:39 UTC 
vim-8.1.1137-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.