Bug 169743

Summary:	Review Request: libibverbs - InfiniBand user access library
Product:	[Fedora] Fedora	Reporter:	Roland Dreier <rolandd>
Component:	Package Review	Assignee:	Ed Hill <ed>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.digitalvampire.org/fedora
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-30 03:45:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 169744

Description Roland Dreier 2005-10-02 21:34:07 UTC

Spec Name or Url: http://www.digitalvampire.org/fedora/libibverbs.spec
SRPM Name or Url: http://www.digitalvampire.org/fedora/libibverbs-1.0-0.1.rc3.src.rpm
Description: 
libibverbs is a library that allows userspace processes to use
InfiniBand "verbs" as described in the InfiniBand Architecture
Specification.  This includes direct hardware access for fast path
operations.


libibverbs is a library for using the "userspace verbs" support that was added in kernel 2.6.13.  I will post a separate review request for the libmthca plug-in, which provides device-specific support for Mellanox InfiniBand hardware.

This is my first package, so I need a sponsor as well.

Thanks, Roland.

Comment 1 Roland Dreier 2005-10-03 03:16:45 UTC

*** Bug 169752 has been marked as a duplicate of this bug. ***

Comment 2 Ed Hill 2005-10-25 02:30:20 UTC

nits:
 - please change Source from:
     http://openib.org/downloads/%{name}-%{ver}.tar.gz
   to:
     http://openib.org/downloads/libibverbs-1.0-rc3.tar.gz
   since the former is an invalid URL

good:
 + license is OK and included per license terms (good!)
 + source matches upstream
 + builds in mock on FC-4
 + spec is clean/readable
 + code not content
 + proper use of devel
 + *.la are deleted and ldconfig OK
 + no complaints or warnings from rpmlint

Unfortunately, I don't have any IB hardware to test it on (we use
Myrinet and/or ethernet for our clusters).

But regardless, this appears to be a good, clean first package.
Congrats!

APPROVED.

And yes, I volunteer to sponsor you so please feel free to contact 
me if you have any questions, etc.

Comment 3 Roland Dreier 2005-10-30 03:45:51 UTC

libibverbs is now in FC-4 and devel.