Bug 1697507

Link to the full log https://rhos-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/DFG/view/df/view/rfe/job/DFG-df-rfe-14-virsh-3cont_2comp_3ceph-dry-run-verification/18/artifact/.sh/verification-run.log

Hello Victor,

It probably don't hit just Rocky, Master should also get it. A patch is provided for Master right now, and will be backported to Rocky once merged.

I'll do some more tests on my own in parallel.

Cheers,

C.

Issue is still present:

puddle id - 2019-04-12.1
openstack-tripleo-heat-templates.noarch 0:9.3.1-0.20190314162756.d0a6cb1.el7ost 

https://rhos-qe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/DFG/view/df/view/rfe/job/DFG-df-rfe-14-virsh-3cont_2comp_3ceph-dry-run-verification/19/artifact/.sh/verification-run.log

Solution that worked for sure for previous bug [1] was to disable the whole block where variable was in use [2]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1684864
[2] https://review.openstack.org/#/c/639402/1/roles/tripleo-ssh-known-hosts/tasks/main.yml

Hello,

This is the "right" solution (at least, it's working): https://review.openstack.org/#/c/652621/

I've tested it with a simple playbook:
- hosts: localhost
  tasks:
    - name: check command
      shell: systemctl is-active rsyslog
      register: rsyslog_config
    - name: push output
      when:
        - rsyslog_config is changed
        - rsyslog_config.rc == 0
      debug:
        var: rsyslog_config

When we run it with --check:
PLAY [localhost] ******************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ************************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [check command] **************************************************************************************************************************************************************************************************************************
skipping: [localhost]

TASK [push output] ****************************************************************************************************************************************************************************************************************************
skipping: [localhost]

PLAY RECAP ************************************************************************************************************************************************************************************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0

And with standard:
PLAY [localhost] ******************************************************************************************************************************************************************************************************************************

TASK [Gathering Facts] ************************************************************************************************************************************************************************************************************************
ok: [localhost]

TASK [check command] **************************************************************************************************************************************************************************************************************************
changed: [localhost]

TASK [push output] ****************************************************************************************************************************************************************************************************************************
ok: [localhost] => {
    "rsyslog_config": {
        "changed": true, 
        "cmd": "systemctl is-active rsyslog", 
        "delta": "0:00:00.006942", 
        "end": "2019-04-15 13:31:58.830151", 
        "failed": false, 
        "rc": 0, 
        "start": "2019-04-15 13:31:58.823209", 
        "stderr": "", 
        "stderr_lines": [], 
        "stdout": "active", 
        "stdout_lines": [
            "active"
        ]
    }
}

PLAY RECAP ************************************************************************************************************************************************************************************************************************************
localhost                  : ok=3    changed=1    unreachable=0    failed=0

Have to make it merge, then backport it into rocky, and finally downstream.

New package should sort the issue. Sorry for the delay :(

"TASK [Forward logging to haproxy.log file] *************************************", "fatal: [controller-2]: FAILED! => {\"msg\": \"The conditional check 'rsyslog_config.rc == 0' failed. The error was: error while evaluating conditional (rsyslog_config.rc == 0): 'dict object' has no attribute 'rc'\\n\\nThe error appears to have been in '/home/stack/config-download/Controller/host_prep_tasks.yaml': line 479, column 5, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n- block:\\n  - blockinfile:\\n    ^ here\\n\"}", "fatal: [controller-1]: FAILED! => {\"msg\": \"The conditional check 'rsyslog_config.rc == 0' failed. The error was: error while evaluating conditional (rsyslog_config.rc == 0): 'dict object' has no attribute 'rc'\\n\\nThe error appears to have been in '/home/stack/config-download/Controller/host_prep_tasks.yaml': line 479, column 5, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n- block:\\n  - blockinfile:\\n    ^ here\\n\"}", "fatal: [controller-0]: FAILED! => {\"msg\": \"The conditional check 'rsyslog_config.rc == 0' failed. The error was: error while evaluating conditional (rsyslog_config.rc == 0): 'dict object' has no attribute 'rc'\\n\\nThe error appears to have been in '/home/stack/config-download/Controller/host_prep_tasks.yaml': line 479, column 5, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n- block:\\n  - blockinfile:\\n    ^ here\\n\"}",


core_puddle 2019-05-31.1

openstack-tripleo-heat-templates-9.3.1-0.20190513171725.9995be9.el7ost.noarch

The fix should be in the compose, but it's missing:

- name: Check if rsyslog exists
  register: rsyslog_config
  shell: systemctl is-active rsyslog
- block:
  - blockinfile:
      content: 'if $syslogfacility-text == ''{{facility}}'' and $programname == ''haproxy''
        then -/var/log/containers/haproxy/haproxy.log

        & stop

        '
      create: true
      path: /etc/rsyslog.d/openstack-haproxy.conf
    name: Forward logging to haproxy.log file
    register: logconfig
    vars:
      facility: local0
  - name: restart rsyslog service after logging conf change
    service:
      name: rsyslog
      state: restarted
    when: logconfig is changed
  when: rsyslog_config.rc == 0
- file:

Hello,

so the backport for pacemaker wasn't done for rocky - the stein one took a long time and got merged only last week - since I was off it wasn't taken down to rocky.

I've just pushed https://review.opendev.org/#/c/664046/ - hopefully it will be merged next week upstream, and I'll backport it now downstream.

Sorry for all those delays.

(added downstream backport for osp-14)

Verified on compose 2019-06-10.3

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1672