Bug 1697773

I'm afraid this is side-effect of enablement QEMU Session by default [0].

Could you try putting ` libvirt.qemu_use_session = false ` in your Vagrantfile?


[0] https://fedoraproject.org/wiki/Changes/Vagrant_2.2_with_QEMU_Session#Upgrade.2Fcompatibility_impact

Yep setting ` libvirt.qemu_use_session = false ` in the Vagrantfile fixes this issue.

    devel.vm.provider "libvirt" do |vm|
      vm.cpus = 2
      vm.driver = "kvm"
      vm.memory = 4096
      vm.nic_model_type = "e1000"
      vm.qemu_use_session = false
    end

This is a pretty breaking change to push out on a non major release without much documentation or clarification. Maybe we can put something in the error message in your upstream PR (https://github.com/vagrant-libvirt/vagrant-libvirt/pull/969) about the network not being available and that this new setting is needed if you want to use a private_network. Then at least it will help end users see that they need to add something to their Vagrantfiles. The private_network setting is heavily used with Ansible when developing playbooks and roles on Vagrant.

I can totally see using QEMU Sessions being enabled by default a major positive thing for new Vagrant users on Fedora so they don't need to muck around with user groups or ACLs.

It would be nice, if with this change, that this option was globally configurable on or off.

To get the old behavior I now have to modify every Vagrantfile as it doesn't play correctly with VM's that were created prior to upgrade.

It also fails to work unless I manually create ~/VirtualMachines

(In reply to Joe Doss from comment #2)
> This is a pretty breaking change to push out on a non major release

We are pushing it in major release, in major release of Fedora, i.e. in F30. This was ours, i.e. maintainers of Vagrant in fedora, decision to change the default, not upstream. And frankly, there is no good time to do this switch, now is as good as tomorrow, because it will definitely break someones setup.

> without much documentation or clarification.

This is properly documented and communicated as far as Fedora standards requires:

https://fedoraproject.org/wiki/Changes/Vagrant_2.2_with_QEMU_Session

This should propagate to Fedora Release notes. If you have some suggestions for improvement of the change proposal, feel free to update the wiki (I assume you are able to edit the page).

(In reply to Jason Montleon from comment #3)
> It would be nice, if with this change, that this option was globally
> configurable on or off.

Well, the problem is that as far as I know, Vagrant doesn't have some global/system configuration file (unless you want to put Vagrantfile into your root directory) :/ But I guess you should be able to change the defaults for your user via ~/.vagrant.d/Vagrantfile

(In reply to Vít Ondruch from comment #4)
> We are pushing it in major release, in major release of Fedora, i.e. in F30.
> This was ours, i.e. maintainers of Vagrant in fedora, decision to change the
> default, not upstream. And frankly, there is no good time to do this switch,
> now is as good as tomorrow, because it will definitely break someones setup.

I should have been more clear. I meant to echo the same sentiment from upstream (https://github.com/vagrant-libvirt/vagrant-libvirt/pull/969#issuecomment-463193072) that changing this default is going to have deep impacts on the current user base. Sorry for not being more clear here. I do agree with you on your points that there is no good time to change this default. I do see the benefits of changing it for new users so I get why you and Pavel made the choice to do it in Fedora 30. 

> This is properly documented and communicated as far as Fedora standards
> requires:
> 
> https://fedoraproject.org/wiki/Changes/Vagrant_2.2_with_QEMU_Session
> 
> This should propagate to Fedora Release notes. If you have some suggestions
> for improvement of the change proposal, feel free to update the wiki (I
> assume you are able to edit the page).

Fair enough. I guess to push things forward to try and prevent other users from being impacted I pushed a PR to upstream that:

* Adds in a new environment variable VAGRANT_LIBVIRT_QEMU_USE_SESSION so you can globally turn off/on QEMU sessions and documents the change.
* Clears up the error "Network X is not available. Specify available network name, or an ip address if you want to create a new network" so it is more clear on what the problem is. 

https://github.com/vagrant-libvirt/vagrant-libvirt/pull/997

(In reply to Joe Doss from comment #6)
> I guess to push things forward to try and prevent other users
> from being impacted I pushed a PR to upstream that:

Thx a lot!

> * Adds in a new environment variable VAGRANT_LIBVIRT_QEMU_USE_SESSION so you
> can globally turn off/on QEMU sessions and documents the change.

Nice, we might consider removing the patch and using the env variable instead.

> * Clears up the error "Network X is not available. Specify available network
> name, or an ip address if you want to create a new network" so it is more
> clear on what the problem is. 

Very useful. Thx.


Do you think we can close this ticket now and probably open new one to consider the env variable and enhancing the error message once accepted (released) upstream?

No problem Vit. Thanks to you and Pavel for your work on Vagrant in Fedora. Let's see what upstream wants to do and I will open a new BZ if they accept my patches so we can include them in Fedora.