Bug 1698157

Summary: python-pyramid-1.10.2-1.fc31 FTBFS with Python 3.8
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-pyramidAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideCC: infra-sig, lewk, rbarlow, rbean, rossdylan, tdabasin
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-pyramid-1.10.4-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-24 07:04:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1699203    
Bug Blocks: 1686977    
Attachments:
Description Flags
Full log from Copr none

Description Miro Hrončok 2019-04-09 17:37:06 UTC
Created attachment 1553905 [details]
Full log from Copr

The %check of pyramid fails with Python 3.8:



======================================================================
FAIL: test_scan_integration_conflict (tests.test_config.test_init.ConfiguratorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/test_init.py", line 1144, in test_scan_integration_conflict
    c.commit()
pyramid.exceptions.ConfigurationConflictError: Conflicting configuration actions
  For: ('view', None, '', None, 'd41d8cd98f00b204e9800998ecf8427e')
    Line 5 of file /builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/pkgs/selfscan/__init__.py:
        def abc(request):
    Line 5 of file /builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/pkgs/selfscan/__init__.py:
        def abc(request):
  For: ('view', None, 'two', None, 'd41d8cd98f00b204e9800998ecf8427e')
    Line 5 of file /builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/pkgs/selfscan/another.py:
        def two(request):
    Line 5 of file /builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/pkgs/selfscan/another.py:
        def two(request):

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/builddir/build/BUILD/python3-python-pyramid-1.10.2-1.fc31/tests/test_config/test_init.py", line 1155, in test_scan_integration_conflict
    self.assertTrue("@view_config(renderer='string')" in which)
AssertionError: False is not true

----------------------------------------------------------------------


Full log attached.

(Note: This is not a chameleon update problem, the same version of chameleon+pyramid builds fine on Python 3.7.)

This blocks the Python 3.8 boostratp towards bodhi and fedpkg.

Comment 1 Miro Hrončok 2019-04-09 18:00:54 UTC
https://github.com/Pylons/pyramid/issues/3471

Comment 2 Miro Hrončok 2019-04-09 18:04:25 UTC
Note that skipping test_scan_integration_conflict seems like a reasonable thing to do.

Comment 3 Randy Barlow 2019-04-17 18:19:53 UTC
Hey Miro!

It looks like that issue was closed by https://github.com/Pylons/pyramid/pull/3483. It also looks like they made a 1.10.4 release, but it seems that only some of the commits from that pull request were included in that release (unless my ctrl-f Firefox skills are failing me): https://github.com/Pylons/pyramid/commits/1.10.4

In particular, I do see https://github.com/Pylons/pyramid/pull/3483/commits/b1c366a5921969254d87ffc2417d39046cffebe3 but do not see https://github.com/Pylons/pyramid/pull/3483/commits/bd51b6c3afb8bd46d37bbf77e208f2e91401b1db. I'm not sure if that's important. They also didn't really mention Python 3.8 much in their release notes: https://docs.pylonsproject.org/projects/pyramid/en/1.10-branch/changes.html#changes-1-10-4. Anyways, maybe we could try 1.10.4 out and see what happens?

Comment 4 Miro Hrončok 2019-04-18 17:11:49 UTC
Thanks. It works. https://src.fedoraproject.org/rpms/python-pyramid/pull-request/3