Bug 1698191

Summary: python-pyramid-mako-1.0.2-9.fc31 FTBFS with Python 3.8
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-pyramid-makoAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: infra-sig, rbean
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-03 09:46:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1700055    
Bug Blocks: 1686977    
Attachments:
Description Flags
Full log from Copr none

Description Miro Hrončok 2019-04-09 19:02:09 UTC
Created attachment 1553918 [details]
Full log from Copr

%check has a test error:

======================================================================
ERROR: test_call_render_raises (pyramid_mako.tests.MakoLookupTemplateRendererTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pyramid_mako-1.0.2/pyramid_mako/__init__.py", line 148, in __call__
    result = template.render_unicode(**system)
  File "/builddir/build/BUILD/pyramid_mako-1.0.2/pyramid_mako/tests.py", line 625, in render_unicode
    raise self.render_exc
NotImplementedError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/builddir/build/BUILD/pyramid_mako-1.0.2/pyramid_mako/tests.py", line 324, in test_call_render_raises
    instance({}, {})
  File "/builddir/build/BUILD/pyramid_mako-1.0.2/pyramid_mako/__init__.py", line 152, in __call__
    errtext = text_error_template().render(
  File "/usr/lib/python3.8/site-packages/mako/exceptions.py", line 236, in text_error_template
    return mako.template.Template(r"""
  File "/usr/lib/python3.8/site-packages/mako/template.py", line 320, in __init__
    (code, module) = _compile_text(self, text, filename)
  File "/usr/lib/python3.8/site-packages/mako/template.py", line 704, in _compile_text
    source, lexer = _compile(template, text, filename,
  File "/usr/lib/python3.8/site-packages/mako/template.py", line 686, in _compile
    source = codegen.compile(node,
  File "/usr/lib/python3.8/site-packages/mako/codegen.py", line 52, in compile
    _GenerateRenderMethod(printer,
  File "/usr/lib/python3.8/site-packages/mako/codegen.py", line 127, in __init__
    args = pagetag.body_decl.get_argument_expressions()
  File "/usr/lib/python3.8/site-packages/mako/ast.py", line 175, in get_argument_expressions
    name, pyparser.ExpressionGenerator(default).value()))
  File "/usr/lib/python3.8/site-packages/mako/pyparser.py", line 230, in __init__
    self.generator.visit(astnode)
  File "/usr/lib/python3.8/site-packages/mako/_ast_util.py", line 279, in visit
    return f(node)
  File "/usr/lib/python3.8/site-packages/mako/_ast_util.py", line 685, in visit_Constant
    self.write(repr(node.n))
AttributeError: 'Constant' object has no attribute 'n'

----------------------------------------------------------------------

Full log attached.

This blocks the Python 3.8 bootstrap towards bodhi and fedpkg.

Comment 1 Miro Hrončok 2019-04-11 13:39:37 UTC
Reported upstream: https://github.com/Pylons/pyramid_mako/issues/47

Comment 2 Miro Hrončok 2019-04-17 10:44:48 UTC
Mako 1.0.9 should fix this.

Comment 3 Miro Hrončok 2019-06-03 09:46:58 UTC
1.0.9 have indeed fixed this.