Bug 1698252
Summary: | Review Request: perl-Test-Data-Split - Split data-driven tests into several test scripts | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Shlomi Fish <shlomif> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jplesnik, package-review |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Test-Data-Split-0.2.1-1.fc31 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-07-03 07:33:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Shlomi Fish
2019-04-09 22:36:41 UTC
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: perl(File::Temp) - t/run.t:77 perl(IPC::Open3) - t/00-compile.t:26 perl(lib) - t/run.t:6 $ rpm -qp --requires perl-Test-Data-Split-0.2.1-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(autodie) 1 perl(Carp) 1 perl(IO::All) 1 perl(:MODULE_COMPAT_5.28.1) 1 perl(MooX) 1 perl(parent) 1 perl(strict) 1 perl(Test::Data::Split::Backend::Hash) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) FIX: Please add run-requires perl(List::MoreUtils) - lib/Test/Data/Split/Backend/Hash.pm:46 $ rpm -qp --provides perl-Test-Data-Split-0.2.1-1.fc31.noarch.rpm | sort | uniq -c 1 perl(Test::Data::Split) = 0.2.1 1 perl-Test-Data-Split = 0.2.1-1.fc31 1 perl(Test::Data::Split::Backend::Hash) = 0.2.1 1 perl(Test::Data::Split::Backend::ValidateHash) = 0.2.1 Binary provides are Ok. $ rpmlint ./perl-Test-Data-Split* perl-Test-Data-Split.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization perl-Test-Data-Split.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok TODO: If you add to command './Build install' option --create_packlist=0 then you can remove the find command for removing packlist files and BR findutils. Please correct all 'FIX' issues and consider fixing 'TODO' items. Otherwise the package looks good. Resolution: Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Data-Split |