Bug 1698586

Summary: Dynamic Dialogs no longer function
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Roman Blanco <rblanco>
Status: CLOSED ERRATA QA Contact: Niyaz Akhtar Ansari <nansari>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.2CC: bmidwood, dluong, dmetzger, eclarizi, gmccullo, greartes, hkataria, jcutter, jprause, kborole, lavenel, mkanoor, mpovolny, mshriver, nansari, ngupta, obarenbo, rchincho, smallamp, sshveta, wfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.10.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.3.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1696474 Environment:
Last Closed: 2019-04-23 07:46:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1696474    
Bug Blocks:    
Attachments:
Description Flags
dynamic fields
none
Dialog used for testing
none
Datastore used in testing none

Comment 2 CFME Bot 2019-04-10 16:57:22 UTC
New commit detected on ManageIQ/ui-components/hammer:

https://github.com/ManageIQ/ui-components/commit/7bca0ba748ef1cb0ad73d80b2ab143ca71b57ae6
commit 7bca0ba748ef1cb0ad73d80b2ab143ca71b57ae6
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Apr 10 12:52:25 2019 -0400
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Apr 10 12:52:25 2019 -0400

    Merge pull request #381 from romanblanco/bz1696474

    Fix for dynamic dialog fields not being updated

    (cherry picked from commit a9c4a08d4856dcde41839260f2db91fddee74777)

    https://bugzilla.redhat.com/show_bug.cgi?id=1698586

 src/dialog-user/components/dialog-user/dialogField.html | 10 +-
 src/dialog-user/components/dialog-user/dialogField.ts | 6 +-
 2 files changed, 9 insertions(+), 7 deletions(-)

Comment 3 Satoe Imaishi 2019-04-10 20:48:04 UTC
The change is included in ui-components 1.1.21

https://github.com/ManageIQ/manageiq-ui-service/pull/1535
https://github.com/ManageIQ/manageiq-ui-classic/pull/5447

Comment 6 CFME Bot 2019-04-11 21:50:56 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/b542dad7429be4fd399203c91c2f91b4b32bbd55
commit b542dad7429be4fd399203c91c2f91b4b32bbd55
Author:     Erik Clarizio <eclarizi>
AuthorDate: Thu Apr 11 14:06:26 2019 -0400
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Apr 11 14:06:26 2019 -0400

    Fix for incorrect key sent back for dynamic non sorted items

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1698586

 app/models/dialog_field_serializer.rb | 4 +-
 spec/models/dialog_field_serializer_spec.rb | 128 +-
 2 files changed, 104 insertions(+), 28 deletions(-)

Comment 7 CFME Bot 2019-04-12 15:51:05 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/98e476cd2b48eefef304d5308ffb77d35706a10f
commit 98e476cd2b48eefef304d5308ffb77d35706a10f
Author:     Erik Clarizio <eclarizi>
AuthorDate: Thu Apr 11 14:06:26 2019 -0400
Commit:     Erik Clarizio <eclarizi>
CommitDate: Thu Apr 11 14:06:26 2019 -0400

    Fix for incorrect key sent back for dynamic non sorted items

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1698586

 app/models/dialog_field_serializer.rb | 4 +-
 spec/models/dialog_field_serializer_spec.rb | 128 +-
 2 files changed, 104 insertions(+), 28 deletions(-)

Comment 8 Niyaz Akhtar Ansari 2019-04-18 16:12:00 UTC
I have tested this BZ in latest build 5.10.3.3 and everything works fine.
Please change the BZ status to ON_QA so I will verify this BZ.

Comment 9 Shveta 2019-04-18 19:10:53 UTC
Created attachment 1556197 [details]
dynamic fields

Dynamic fields like Master appliance , limit and vm_name_playbook are populated by data from automate domain methods.

Tested on 5.10.3.3.20190415203225_deb61ff

Comment 10 Shveta 2019-04-18 19:12:05 UTC
Created attachment 1556198 [details]
Dialog used for testing

Comment 11 Shveta 2019-04-18 19:12:39 UTC
Created attachment 1556199 [details]
Datastore used in testing

Comment 12 Sudhir Mallamprabhakara 2019-04-19 09:53:03 UTC
marking this as verified.

Comment 15 errata-xmlrpc 2019-04-23 07:46:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0796

Comment 16 William Fitzgerald 2019-05-15 20:10:55 UTC
Works properly using Admin UI on a hammer-5.20190424144425_1d4816f upstream appliance
with this fix manually applied:  https://github.com/ManageIQ/ui-components/pull/384