Bug 1698879

Summary:	RFE: support multiselection in Details->Storage
Product:	[Community] Virtualization Tools	Reporter:	Martin Kolman <mkolman>
Component:	virt-manager	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	berrange, crobinso, gscrivan, tburke
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-26 21:30:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kolman 2019-04-11 12:34:07 UTC

Description of problem:
The Anaconda team runs installer integration tests in VMs on libvirt hypervisors with a lot of temporary VMs that are dynamically created and then discarded when they finish an installation run. By some not yet clear mechanism these temporary VMs sometimes leave leftover stale pools.

The problem is that the list of pools in the Storage tab of the Details dialog does not support multi selection + requires you to confirm any delete operation.

So in case you have a couple dozen of these stale pools on each of multiple hypervisors, deleting them is quite a slow and tedious experience.

Ideally there should be a multi-selection mechanism, so that multiple pools can be selected (with ctrl or shift as usual) and the deleted at once with a single confirmation dialog. IIRC VM snapshots already support something like that.

Version-Release number of selected component (if applicable):
2.1.0

How reproducible:
always

Steps to Reproduce:
1. connect to a hypervisior that has multiple pools attached
2. go to the Details dialog for the hypervisor
3. got to the Storage tab
4. try to delete multiple pools

Actual results:
Pools can be only deleted one-by-one and each delete operation spawns a confirm dialog that needs to be clicked on as well.

Expected results:
Multiple pools can be selected with the standard ctrl/shift shortcut:
- holding ctrl selects/unselects individual pools
- holding shift selects a range of pools from current selection (if any)
Once multiple pools are selected, a single confirmation dialog needs to be clicked, something like: "Do you want to delete these 35 pools ?".

Comment 1 Cole Robinson 2020-01-26 21:30:35 UTC

Thanks for the suggestion. I remember the case that prompted this request and I sympathize.
But these types of multi object operations are something I am wary of opening the door for.
It's a very slippery slope into getting requests for multi object operations all across
the app, and UI extensions to handle lots of VMs, which is generally outside the intended
audience of virt-manager. See the recently published design document if you want more info.
https://github.com/virt-manager/virt-manager/blob/master/DESIGN.md

For these types of bulk operations you can always go to the command line and use virsh.
For virt-manager this is WONTFIX though, sorry