Bug 1699280

Proposed as a Blocker and Freeze Exception for 30-final by Fedora user rdieter using the blocker tracking app because:

 Not sure what's going on here, but I suspect it's related to breeze-icon-theme trigger scriptlets.  dnf error output is a little unhelpful, but the impact is that if unfix, means no one will be able to install f30 via kickstart if breeze-icon-theme is included in the transaction.

Here's what breeze-icon-theme.spec currently includes wrt scriptlets, if anyone can spot what's going wrong.  Included only snippets related to breeze theme, these are duplicated for breeze-dark too:

%filetriggerin -- %{_datadir}/icons/breeze
touch %{_datadir}/icons/breeze &> /dev/null || :

%transfiletriggerin -- %{_datadir}/icons/breeze
gtk-update-icon-cache %{_datadir}/icons/breeze &>/dev/null || :

# arg, looks like this case cannot be handled by triggers? -- rex
%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/breeze &> /dev/null || :
touch --no-create %{_datadir}/icons/breeze-dark &> /dev/null || :
fi

%transfiletriggerpostun -- %{_datadir}/icons/breeze
gtk-update-icon-cache %{_datadir}/icons/breeze &>/dev/null || :


adwaita for comparison does less, 

%transfiletriggerin -- %{_datadir}/icons/Adwaita
gtk-update-icon-cache --force %{_datadir}/icons/Adwaita &>/dev/null || :

%transfiletriggerpostun -- %{_datadir}/icons/Adwaita
gtk-update-icon-cache --force %{_datadir}/icons/Adwaita &>/dev/null || :


I'm thinking I tried too hard to ensure gtk-update-icon-cache only ran once per transaction, and broke things?  I'll make breeze match the adwaita style and see if that helps.

breeze-icon-theme-5.57.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7706906b7f

Hi Rex

Thanks for the new packages, but I'm still seeing the same issue:

From packaging.log..

06:50:22,919 INF packaging: Installed: breeze-icon-theme-5.57.0-1.fc30.noarch 1555170077 295c69a8b63e4dc518277858a39d12e2341dd9b2ce2c6559c15a1e1df4ac769e
06:50:32,586 INF packaging: Configuring (running scriptlet for): breeze-icon-theme-5.57.0-1.fc30.noarch 1555170077 295c69a8b63e4dc518277858a39d12e2341dd9b2ce2c6559c15a1e1df4ac769e
06:50:32,605 ERR dnf.rpm: Error in <unknown> scriptlet in rpm package breeze-icon-theme
06:50:32,637 ERR dnf.rpm: Error in <unknown> scriptlet in rpm package breeze-icon-theme
06:50:32,660 ERR dnf.rpm: Error in <unknown> scriptlet in rpm package breeze-icon-theme

Roderick

Sorry -2 was the real fixed build

I'm not seeing the -2 at: https://bodhi.fedoraproject.org/updates/?packages=breeze-icon-theme yet. Does it take a while to appear?

breeze-icon-theme-5.57.0-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7706906b7f

Thanks. That works nicely.

For me, the version 5.57.0-2 works.

Discussed during the 2019-04-15 blocker review meeting: [1]

The decision to classify this bug as a "RejectedBlocker" and an "AcceptedFreezeException" was made as the current criteria do not really cover this, the existing requirement in historical context covered the pre-Fedora.next default install which was GNOME. We believe the criterion could be revisited, but as this bug is fixed anyway, we will handle that separately.

[1] https://meetbot.fedoraproject.org/fedora-blocker-review/2019-04-15/f30-blocker-review.2019-04-15-16.03.txt

breeze-icon-theme-5.57.0-2.fc30, oxygen-icon-theme-5.57.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7706906b7f

breeze-icon-theme-5.57.0-2.fc30, oxygen-icon-theme-5.57.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.