Bug 1699308

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=34125497

Same comment about Changelog:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs

Is the Requires:aom really necessary? The binary already depends on libaom.so.0.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 11 files have unknown license. Detailed
     output of licensecheck in 1699308-go-avif/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-kagami-avif-devel , go-avif-debuginfo , go-avif-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: go-avif-0.1.0-1.fc31.x86_64.rpm
          golang-github-kagami-avif-devel-0.1.0-1.fc31.noarch.rpm
          go-avif-debuginfo-0.1.0-1.fc31.x86_64.rpm
          go-avif-debugsource-0.1.0-1.fc31.x86_64.rpm
          go-avif-0.1.0-1.fc31.src.rpm
go-avif.x86_64: W: spelling-error %description -l en_US libaom -> libation
go-avif.x86_64: W: no-manual-page-for-binary go-avif
golang-github-kagami-avif-devel.noarch: W: spelling-error %description -l en_US libaom -> libation
golang-github-kagami-avif-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/Kagami/go-avif/.goipath
go-avif.src: W: spelling-error %description -l en_US libaom -> libation
5 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (debuginfo)
-------------------
Checking: go-avif-debuginfo-0.1.0-1.fc31.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "en_CA.utf8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
go-avif.x86_64: W: spelling-error %description -l en_US libaom -> libation
go-avif.x86_64: W: invalid-url URL: https://github.com/Kagami/go-avif <urlopen error [Errno -2] Name or service not known>
go-avif.x86_64: W: no-manual-page-for-binary go-avif
golang-github-kagami-avif-devel.noarch: W: spelling-error %description -l en_US libaom -> libation
golang-github-kagami-avif-devel.noarch: W: invalid-url URL: https://github.com/Kagami/go-avif <urlopen error [Errno -2] Name or service not known>
golang-github-kagami-avif-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/Kagami/go-avif/.goipath
go-avif-debuginfo.x86_64: W: invalid-url URL: https://github.com/Kagami/go-avif <urlopen error [Errno -2] Name or service not known>
go-avif-debugsource.x86_64: W: invalid-url URL: https://github.com/Kagami/go-avif <urlopen error [Errno -2] Name or service not known>
4 packages and 0 specfiles checked; 0 errors, 8 warnings.



Requires
--------
go-avif (rpmlib, GLIBC filtered):
    aom
    libaom.so.0()(64bit)
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

golang-github-kagami-avif-devel (rpmlib, GLIBC filtered):
    golang(github.com/docopt/docopt-go)
    pkgconfig(aom)

go-avif-debuginfo (rpmlib, GLIBC filtered):

go-avif-debugsource (rpmlib, GLIBC filtered):



Provides
--------
go-avif:
    go-avif
    go-avif(x86-64)

golang-github-kagami-avif-devel:
    golang(github.com/Kagami/go-avif)
    golang-github-kagami-avif-devel
    golang-ipath(github.com/Kagami/go-avif)

go-avif-debuginfo:
    debuginfo(build-id)
    go-avif-debuginfo
    go-avif-debuginfo(x86-64)

go-avif-debugsource:
    go-avif-debugsource
    go-avif-debugsource(x86-64)



Source checksums
----------------
https://github.com/Kagami/go-avif/archive/v0.1.0.tar.gz#/go-avif-0.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : db91278483216cfe5f58667203cd9d9ac314a5cb32ba820455e06658561ea975
  CHECKSUM(SHA256) upstream package : db91278483216cfe5f58667203cd9d9ac314a5cb32ba820455e06658561ea975


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1699308 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(In reply to Elliott Sales de Andrade from comment #2)
> Same comment about Changelog:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
> 

It's the new format prescribed by rpm 4.14:

Add support for date-style full timestamps in %changelog (trac:903)

https://rpm.org/wiki/Releases/4.14.0

Thanks for the review.

I've removed the Require.

Spec URL: https://eclipseo.fedorapeople.org/for-review/go-avif.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/go-avif-0.1.0-1.fc31.src.rpm

New in rpm doesn't necessarily mean approved by guidelines though. However, since they're all over existing specs I'm not going to block on it.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/go-avif

go-avif-0.1.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c357235459

go-avif-0.1.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-618a8dd68e

go-avif-0.1.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c357235459

go-avif-0.1.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-618a8dd68e

go-avif-0.1.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

go-avif-0.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.