Bug 1699322
| Summary: | Button group is disabled if all button are disabled | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Christian Jung <cbolz> | |
| Component: | UI - OPS | Assignee: | Martin Povolny <mpovolny> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nikhil Dhandre <ndhandre> | |
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | |
| Priority: | high | |||
| Version: | 5.10.0 | CC: | bmidwood, dhalasz, dmetzger, hkataria, lavenel, mpovolny, mshriver, obarenbo, simaishi | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.11.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.11.0.1 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1705141 (view as bug list) | Environment: | ||
| Last Closed: | 2019-12-13 14:54:14 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | CFME Core | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1705141 | |||
Please assess the impact of this issue and update the severity accordingly. Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition. If it's something like a tracker bug where it doesn't matter, please set the severity to Low. Yes, this is "works as designed" however you are not the 1st to complain. Christian, can you, please, check if this: https://github.com/ManageIQ/ui-components/pull/372 Resolves the issue for you? It does not re-enable the drop-down, but it shows the messages from the child buttons. Thank you! HiHo, yes, the PR sounds like an acceptable compromise. My personal preference would be the "Dashes - one dash - single newline" variant. Would it be possible to get a hotfix so we can get this integrated into our MBU Lab before Summit? We have a Lab showing students how to use the Visibility and Enablement in buttons and IMHO the current behavior is not particularly user friendly. Thanks in advance, CHristian UI PR with the dependencies update for the toolbar component: https://github.com/ManageIQ/manageiq-ui-classic/pull/5441 For those interested in how this happened here's a link for a "blocker" and "regression" BZ that triggered change to the behavior. https://bugzilla.redhat.com/show_bug.cgi?id=1633727 David, can a quickfix for Christian be created from your fix? For 5.10 I read on top of this BZ. David, can I pass this BZ to you? Tested with Version 5.11.0.2.20190430174828_0e34dea worked fine for me.... some observations 1. When all the buttons are disabled... Group dropdown is disabled and disables msg in itemize type. 2. when at least one button enables.... Group dropdown is enabled and disables msg show on the perticular disabled button. |
Description of problem: Since 4.6 we can define an "Enablement" for custom buttons which improves user experience a lot. If a button is not enabled a "Disabled Button Text" can be presented to the user providing guidance and additional details. If all buttons in a button group are disabled because the "enablement Expression" was not successful, the entire button group becomes disabled. This is an issue since the user can not see the "Disabled Button Text" and does not know how to fix the situation. Version-Release number of selected component (if applicable): 5.9 and above How reproducible: always Steps to Reproduce: 1. create a button group 2. create an "enablement expression" (e.g. VM is powered on) 3. make sure the condition is not met (aka the VM is not running) 4. navigate to a VM Actual results: the button group is disabled ("greyed out") and the "Disabled Button Text" is not shown. Expected results: The button group should be enabled and all inactive buttons should be visible providing their respective "Disabled Button Text" Additional info: There will be a lab at the Partner Conference and at RH Summit where we will hit this bug. Lab draft can be found here: https://gitlab.com/cjung/partner-conference-2019/blob/master/cloudforms-and-ansible-deep-dive/lab/index.md#configure-enablement Follow provided steps to reproduce.