Bug 1699487

 - Not used:

BuildRoot:      %{_tmppath}/%{name}-%{version}-build

 - Missing isa:

Requires:   %{name}%{?_isa} = %{version}-%{release}

 - mkdir -p %{buildroot}/usr/share/cmake/kim-api 

→

mkdir -p %{buildroot}%{_datadir}/cmake/kim-api

 - Own %{_libexecdir}/kim-api

%dir %{_libexecdir}/kim-api

 - In onder to avoid unirtentional soname bumps, globbing the major soname version is now forbidden, be more specific instead:

%{_libdir}/libkim-api.so.*

 - use %global, not %define



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Common Development and Distribution
     License (v1.0)", "Common Development and Distribution License (v3.0)",
     "Artistic License". 16 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/kim-api/review-kim-
     api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/libexec/kim-api
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/cmake(rapidjson-
     devel, glm-devel, libwbxml-devel, python3-uranium, bash-completion,
     python3-uranium-lulzbot, cmake-filesystem, cereal-devel, paraview-
     devel, websocketpp-devel, libmodman-devel, viennacl-devel),
     /usr/share/cmake/Modules(libwbxml-devel, python3-uranium, libmodman-
     devel, python3-uranium-lulzbot, cmake-filesystem, libsolv-devel,
     viennacl-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Buildroot is not present
     Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-build
     See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kim-api
     , kim-api-devel , kim-api-examples
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define compdir %(pkg-config
     --variable=completionsdir bash-completion), %define compdir
     "/etc/bash_completion.d"
[x]: Reviewer should test that the package builds in mock.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kim-api-2.0.2-1.fc31.x86_64.rpm
          kim-api-devel-2.0.2-1.fc31.x86_64.rpm
          kim-api-examples-2.0.2-1.fc31.x86_64.rpm
          kim-api-debuginfo-2.0.2-1.fc31.x86_64.rpm
          kim-api-debugsource-2.0.2-1.fc31.x86_64.rpm
          kim-api-2.0.2-1.fc31.src.rpm
kim-api.x86_64: W: no-manual-page-for-binary kim-api-collections-management
kim-api-devel.x86_64: W: no-documentation
kim-api-examples.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 3 warnings.

(In reply to Robert-André Mauchin from comment #1)
>  - Not used:
> 
> BuildRoot:      %{_tmppath}/%{name}-%{version}-build
Removed

> 
>  - Missing isa:
> 
> Requires:   %{name}%{?_isa} = %{version}-%{release}
Added

> 
>  - mkdir -p %{buildroot}/usr/share/cmake/kim-api 
> 
> →
> 
> mkdir -p %{buildroot}%{_datadir}/cmake/kim-api
Changed

> 
>  - Own %{_libexecdir}/kim-api
> 
> %dir %{_libexecdir}/kim-api
Added

> 
>  - In onder to avoid unirtentional soname bumps, globbing the major soname
> version is now forbidden, be more specific instead:
> 
> %{_libdir}/libkim-api.so.*
Added, %global sover

> 
>  - use %global, not %define
Changed

> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/libexec/kim-api
Fixed.

> [!]: Buildroot is not present
>      Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-build
>      See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
Fixed.

> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kim-api
>      , kim-api-devel , kim-api-examples
Fixed

> [!]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %define compdir %(pkg-config
>      --variable=completionsdir bash-completion), %define compdir
>      "/etc/bash_completion.d"
Fixed

Spec URL: https://junghans.fedorapeople.org/kim-api.spec
SRPM URL: https://junghans.fedorapeople.org/kim-api-2.0.2-2.fc31.src.rpm
TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=34155946

LGTM, package approved.

(In reply to Robert-André Mauchin from comment #3)
> LGTM, package approved.

Thanks.

https://pagure.io/releng/fedora-scm-requests/issue/11065

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/kim-api

kim-api-2.0.2-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-be96c73ae9

kim-api-2.0.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1eec88ee5d

kim-api-2.0.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8cb688e233

kim-api-2.0.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4434bd815d

kim-api-2.0.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-be96c73ae9

kim-api-2.0.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8cb688e233

kim-api-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-4434bd815d

kim-api-2.0.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1eec88ee5d

*** Bug 1700469 has been marked as a duplicate of this bug. ***

kim-api-2.0.2-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

kim-api-2.0.2-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

The actual models are in a different package, which is under review here: https://bugzilla.redhat.com/show_bug.cgi?id=1703235

kim-api-2.0.2-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

kim-api-2.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.