Bug 1699505 (rust-sd)

Summary:	Review Request: rust-sd - An intuitive find & replace CLI
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <eclipseo>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-04-24 07:35:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1699493, 1699498
Bug Blocks:

Description Robert-André Mauchin 🐧 2019-04-13 01:10:39 UTC

Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-sd.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-sd-0.5.0-1.fc31.src.rpm

Description:
An intuitive find & replace CLI.

Fedora Account System Username: eclipseo

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-04-21 09:28:21 UTC

FTBFS in rawhide with:

No matching package to install: '(crate(atomicwrites/default) >= 0.2.2 with crate(atomicwrites/default) < 0.3.0)'
No matching package to install: '(crate(unescape/default) >= 0.1.0 with crate(unescape/default) < 0.2.0)'

Comment 2 Robert-André Mauchin 🐧 2019-04-21 10:14:57 UTC

Thanks for the review.

I forgot to link the deps.

Comment 3 Zbigniew Jędrzejewski-Szmek 2019-04-21 16:10:04 UTC

This is an automatically generated crate package, so just a quick check:
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ latest version

Package name matches executable name. The executable name is short, but does not
seem to conflict with anything.

Package is APPROVED.

It would be useful to add a link to https://crates.io/crates/sd#quick-guide
somewhere. Maybe even both in --help output and %description.

Comment 4 Zbigniew Jędrzejewski-Szmek 2019-04-21 16:10:34 UTC

I forgot to add:
+ seems to work as advertised

Comment 5 Igor Raits 2019-04-22 07:36:47 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sd