Bug 169973

Summary: Review Request: python-clientform - ClientForm
Product: [Fedora] Fedora Reporter: Josh Boyer <jwboyer>
Component: Package ReviewAssignee: John Mahowald <jpmahowald>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://wwwsearch.sourceforge.net/ClientForm/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-11-04 03:51:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Josh Boyer 2005-10-06 00:04:35 UTC 
Spec Name or Url: http://jdub.homelinux.org/files/ClientForm/ClientForm.spec
SRPM Name or Url: http://jdub.homelinux.org/files/ClientForm/lientForm-0.1.17-1.src.rpm

Description: <description here>

ClientForm is a Python module for handling HTML forms on the client side,
useful for parsing HTML forms, filling them in and returning the completed
forms to the server.  It developed from a port of Gisle Aas' Perl module
HTML::Form, from the libwww-perl library, but the interface is not the same.
Comment 1 Ville Skyttä 2005-10-06 15:37:56 UTC 
I'd personally name it "python-clientform" (all lowercase).  Please at least 
add the "python-" prefix.
Comment 2 Ignacio Vazquez-Abrams 2005-10-06 16:11:14 UTC 
The module name is ClientForm so the proper name would be python-ClientForm.
Comment 3 Ville Skyttä 2005-10-06 16:19:12 UTC 
The majority of python-* in Extras seem to disagree with that (based on 
quickly peeking into the source tarball names only).
Comment 4 Tom "spot" Callaway 2005-10-06 16:20:56 UTC 
The prefix is a MUST. The lowercase is up to the packager.
Comment 5 Josh Boyer 2005-10-06 17:31:16 UTC 
Ok, updated spec file and srpm at:

http://jdub.homelinux.org/files/ClientForm/python-clientform.spec

and
http://jdub.homelinux.org/files/ClientForm/python-clientform-0.1.17-2.src.rpm
Comment 6 John Mahowald 2005-10-30 06:58:07 UTC 
Needs work:

- *.pyo needs to be %ghost ed

Summary doesn't seem to match the package:
Summary:        Powerful extensions to the standard datetime module
Is this the right Summary?

Minor:
- typo in Source1, net not not:
http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz

Good:
- BSD license, text included
- spec legible
- source matches upstream
- builds on FC4
- follows python template
- owns all it's files
- rpmlint clean
Comment 7 Josh Boyer 2005-10-30 20:36:08 UTC 
(In reply to comment #6)
> Needs work:
> 
> - *.pyo needs to be %ghost ed

Ok, I think I fixed this... (first time packaging python)

> 
> Summary doesn't seem to match the package:
> Summary:        Powerful extensions to the standard datetime module
> Is this the right Summary?

No.  Blatant copy/paste error.  Fixed.

> 
> Minor:
> - typo in Source1, net not not:
> http://wwwsearch.sourceforge.not/ClientForm/src/ClientForm-0.1.17.tar.gz

Fixed.

Updated spec files and srpm at:

http://jdub.homelinux.org/files/ClientForm/python-clientform.spec

and

http://jdub.homelinux.org/files/ClientForm/python-clientform-0.1.17-3.src.rpm
Comment 8 John Mahowald 2005-10-31 06:44:40 UTC 
Looks good. APPROVED
Comment 9 Josh Boyer 2005-11-04 03:51:10 UTC 
branched, tagged, and built.  thanks for the review!
Comment 10 Christian Iseli 2006-10-18 12:41:35 UTC 
Normalize summary field for easy parsing