Bug 1699745

Summary:	Failed ld plt-main/pltgot test cases
Product:	Red Hat Enterprise Linux 7	Reporter:	Miloš Prchlík <mprchlik>
Component:	binutils	Assignee:	Nick Clifton <nickc>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-tools-bugs
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.7	CC:	fweimer, law, mcermak, mprchlik, ohudlick
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	binutils-2.27-41.base.el7	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-08-06 12:41:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miloš Prchlík 2019-04-15 07:09:38 UTC

Description of problem:

The latest run of upstream test suite reports following failed ld test cases:

FAIL: Build plt-main
FAIL: Build plt-main with PIE
FAIL: Build plt-main with PIE and -z bndplt
FAIL: Build plt-main with -z bndplt
FAIL: ld-x86-64/pltgot-1
FAIL: ld-x86-64/pltgot-2

I saved the whole buildroot (test suite was started after `rpmbuild -bb` in rpmbuild's BUILD) if it's of any help. If not, please let me know what'd help and I try to update my test suite wrapper to include such info.


Version-Release number of selected component (if applicable):

binutils-2.27-40.base.el7


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Nick Clifton 2019-04-15 08:10:27 UTC

Hi Miloš,

> FAIL: Build plt-main


> I saved the whole buildroot (test suite was started after `rpmbuild -bb` in
> rpmbuild's BUILD) if it's of any help.

Yes - are you able to upload the ld.log file from the failing linker tests ?
In particular I want to find out why the build of plt-main failed, as this
is probably the cause of all of the following failures as well.

Cheers
  Nick

Comment 3 Miloš Prchlík 2019-04-15 09:52:30 UTC

(In reply to Nick Clifton from comment #2)
> Hi Miloš,
> 
> > FAIL: Build plt-main
> 
> 
> > I saved the whole buildroot (test suite was started after `rpmbuild -bb` in
> > rpmbuild's BUILD) if it's of any help.
> 
> Yes - are you able to upload the ld.log file from the failing linker tests ?
> In particular I want to find out why the build of plt-main failed, as this
> is probably the cause of all of the following failures as well.
> 
> Cheers
>   Nick

Oh, I forgot to link the saved buildroot in the report :(

https://beaker.engineering.redhat.com/recipes/6729575/tasks/91015902/logs/buildroot.tgz

And extracted ld.log is here: http://nest.test.redhat.com/mnt/qa/scratch/mprchlik/bz1699745-ld.log

Comment 4 Nick Clifton 2019-04-15 12:12:38 UTC

Hi Milos,

  OK, I have managed to reproduce the problem and determine the cause.
  Fortunately the issue is a mistake in the linker testsuite.  Or more
  precisely it is a mistake in the patch that disables the generation
  of the R_X86_64_GOTPCRELX relocs.  This patch changes the relocations
  that are generated by the linker, but it failed to update the testsuite
  to take this into account.  (Actually the patch does update the
  testsuite, but it missed these checks).

  I will create a patch to fix the tests and check it in once it is ready.

Cheers
  Nick

Comment 5 Nick Clifton 2019-04-15 13:13:46 UTC

Fixed in binutils-2.27-41.base.el7

Comment 7 Miloš Prchlík 2019-06-11 11:26:14 UTC

Verified with binutils-2.27-41.base.el7.

Comment 9 errata-xmlrpc 2019-08-06 12:41:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2075