Bug 1699820

From controller-manager logs:

E0415 09:42:38.175328       1 vsphere.go:1235] Failed to create a vsphere volume with volumeOptions: &{CapacityKB:1 Tags:map[kubernetes.io/created-for/pvc/namespace:e2e-tests-statefulset-tccjc kubernetes.io/created-for/pvc/name:datadir-ss-0 kubernetes.io/created-for/pv/name:pvc-a382b675-5f62-11e9-a278-0050569be521] Name:kubernetes-dynamic-pvc-a382b675-5f62-11e9-a278-0050569be521 DiskFormat:thin Datastore:nvme-ds1 VSANStorageProfileData: StoragePolicyName: StoragePolicyID: SCSIControllerType:lsiLogic} on datastore: nvme-ds1. err: A specified parameter was not correct: 
I0415 09:42:38.175408       1 pv_controller.go:1511] failed to provision volume for claim "e2e-tests-statefulset-tccjc/datadir-ss-0" with StorageClass "thin": A specified parameter was not correct: 


On the other hand, this one succeeded:
I0415 09:31:24.084023       1 vsphere.go:1149] Starting to create a vSphere volume with volumeOptions: &{CapacityKB:1048576 Tags:map[kubernetes.io/created-for/pv/name:pvc-3c5ad65b-5f61-11e9-b12c-0050569bb200 kubernetes.io/created-for/pvc/namespace:pvc-test kubernetes.io/created-for/pvc/name:foo] Name:kubernetes-dynamic-pvc-3c5ad65b-5f61-11e9-b12c-0050569bb200 DiskFormat:thin Datastore: VSANStorageProfileData: StoragePolicyName: StoragePolicyID: SCSIControllerType:}
I0415 09:31:24.225370       1 vsphere_volume_util.go:157] Successfully created vsphere volume kubernetes-dynamic-pvc-3c5ad65b-5f61-11e9-b12c-0050569bb200


Size seems to be the root cause.

Upstream issue: https://github.com/kubernetes/kubernetes/issues/43319
Closed without a patch.

Can we make this bz about the error message? Fin a way to state specifically which parameter was incorrect? (or just round the 1b up to 1G like supposedly other things do?)

Storage plugins treat numbers-only storage size as bytes, however, they round it up to the nearest allocation unit (which that may vary from provider to provider).

The exception here is Vsphere that simply converts the value to KiB. For the sake of consistency, I think we should do the same with Vsphere.

PRs submited and waiting for review:

Upstream: https://github.com/kubernetes/kubernetes/pull/76719
OpenShift https://github.com/openshift/origin/pull/22580

Both PRs were merged.

Tested on below version:

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.1.0-0.nightly-2019-05-04-210601   True        False         3h59m   Cluster version is 4.1.0-0.nightly-2019-05-04-210601

Created a pvc without unit:
$ cat pvc.json 
{
    "apiVersion": "v1",
    "kind": "PersistentVolumeClaim",
    "metadata": {
        "name": "pvc"
    },
    "spec": {
        "accessModes": [ "ReadWriteOnce" ],
        "resources": {
            "requests": {
                "storage": "1"
            }
        }
    }
}

$ oc get pvc
NAME   STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
pvc    Bound    pvc-ceb05d1a-6efe-11e9-b2ad-0050568bed6f   1Mi        RWO            thin           2m36s

PVC bound with the nearest allocation unit of "Mi"

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758