Bug 1700524

Summary: Automate - cannot initiate new retirement from Automate method
Product: Red Hat CloudForms Management Engine Reporter: Tina Fitzgerald <tfitzger>
Component: AutomateAssignee: Lucy Fu <lufu>
Status: CLOSED CURRENTRELEASE QA Contact: Ganesh Hubale <ghubale>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.3CC: brant.evans, dmetzger, duhlmann, gmccullo, jcutter, jocarter, mkanoor, mshriver, obarenbo, simaishi, wfitzger
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.19 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1753669 (view as bug list) Environment:
Last Closed: 2019-12-13 14:57:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1753669    

Description Tina Fitzgerald 2019-04-16 19:34:32 UTC
Description of problem:

The retire_now method can be called from an Automate method.
Retirement has been changed to create a request. We need the ability to call the new retirement method from Automate.  

Actual results:
Cannot initiate new retirement from Automate method.

Expected results:
To be able to initiate new retirement from Automate method.

Comment 2 Dave Johnson 2019-04-16 20:01:24 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 4 drew uhlmann 2019-04-24 19:13:36 UTC
Okay, scratch that. 
Ignore comment 3 please. 

The PRs are 
https://github.com/ManageIQ/manageiq/pull/18685 and
https://github.com/ManageIQ/manageiq-automation_engine/pull/314

Comment 6 Ganesh Hubale 2019-05-07 11:51:39 UTC
Sorry,

Mistakenly, I verified this BZ with wrong info in above comment - 5 https://bugzilla.redhat.com/show_bug.cgi?id=1700524#c5

Comment 11 Tina Fitzgerald 2019-08-06 16:07:02 UTC
Working on PR feedback: https://github.com/ManageIQ/manageiq-automation_engine/pull/321

Comment 12 CFME Bot 2019-08-09 21:21:56 UTC
New commit detected on ManageIQ/manageiq-automation_engine/ivanchuk:

https://github.com/ManageIQ/manageiq-automation_engine/commit/c0db041908372ace68173151ba6e8faf654b5df6
commit c0db041908372ace68173151ba6e8faf654b5df6
Author:     Greg McCullough <gmccullo>
AuthorDate: Fri Aug  9 12:24:17 2019 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Fri Aug  9 12:24:17 2019 -0400

    Merge pull request #321 from tinaafitz/fix_retire_request

    Fix call to make_retire_request.

    (cherry picked from commit 566d59a1bebefdc0a2ad6b63fa256276df13e2d3)

    https://bugzilla.redhat.com/show_bug.cgi?id=1700524

 lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_methods.rb | 4 +-
 spec/engine/miq_ae_method_service/miq_ae_service_methods_spec.rb | 28 +-
 2 files changed, 20 insertions(+), 12 deletions(-)

Comment 14 Ganesh Hubale 2019-08-21 08:19:35 UTC
Fixed!

Verified on version: 5.11.0.19.20190813184334_ed72c9f