Bug 1700592
| Summary: | NetworkAttachmentDefinition plural resource name should match convention of other resource names | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Robert Bost <rbost> |
| Component: | Networking | Assignee: | Dan Williams <dcbw> |
| Status: | CLOSED WONTFIX | QA Contact: | Meng Bo <bmeng> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 4.1.0 | CC: | aos-bugs, cdc |
| Target Milestone: | --- | ||
| Target Release: | 4.1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-24 16:45:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1664187 | ||
Nevertheless, this is a 4.1 blocker since we need to release this before we release. dcbw, can you take care of this? Looks like convention would be "networkattachmentdefinitions" (eg without hyphens), not camelCase. But in the end, this would deviate from the upstream NPWG Specification section 3.1: https://github.com/K8sNetworkPlumbingWG/multi-net-spec/blob/master/%5Bv1%5D%20Kubernetes%20Network%20Custom%20Resource%20Definition%20De-facto%20Standard.md We can either (or both): 1) change that in openshift locally and add some short names 2) propose that change upstream We've decided to just stick with the upstream spec, even though it doesn't match the convention. |
The NetworkAttachmentDefinition plural form is currently 'network-attachment-definitions' but this should match the camelCase convention of all other resources in OCP4 cluster. $ oc describe crd network-attachment-definitions.k8s.cni.cncf.io | grep -A5 'Accepted Names:' Accepted Names: Kind: NetworkAttachmentDefinition List Kind: NetworkAttachmentDefinitionList Plural: network-attachment-definitions Short Names: net-attach-def $ oc version Client Version: version.Info{Major:"4", Minor:"0+", GitVersion:"v4.0.22", GitCommit:"219bbe2f0c", GitTreeState:"", BuildDate:"2019-03-10T22:23:11Z", GoVersion:"", Compiler:"", Platform:""} Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.4+0ba401e", GitCommit:"0ba401e", GitTreeState:"clean", BuildDate:"2019-03-31T22:28:12Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"} I believe this will need to be changed in the image resources: https://github.com/openshift/multus-cni/tree/master/images Marking low severity since this doesn't prevent any real behaviours.