Bug 1701

Summary: gnome-pty-helper's Unix98 pty support is broken.
Product: [Retired] Red Hat Linux Reporter: Bill Nottingham <notting>
Component: gnome-libsAssignee: Michael Fulbright <msf>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 1999-03-24 16:57:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Bill Nottingham 1999-03-23 20:10:17 UTC
It creates /dev/pts entries owned by root,
not by the actual user. This causes problems
later on when you try to write to your
own terminal...

Comment 1 Bill Nottingham 1999-03-23 20:46:59 UTC
The following patch should fix it:
--- gnome-libs-1.0.3/zvt/gnome-pty-helper.c.orig	Tue Mar 23 15:36:14
1999+++ gnome-libs-1.0.3/zvt/gnome-pty-helper.c	Tue Mar 23 15:41:11
1999
@@ -284,7 +284,11 @@
 		exit (1);
 	}

+        setegid(pwent->pw_gid);
+        seteuid(pwent->pw_uid);
 	status = openpty (&master_pty, &slave_pty, term_name, NULL, NULL);
+        setuid(getuid());
+        setgid(getgid());
 	if (status == -1){
 		result = 0;
 		write (STDIN_FILENO, &result, sizeof (result));

Comment 2 Michael Fulbright 1999-03-24 16:57:59 UTC
I will be using the patch supplied when building gnome-core,
and I have submitted the patch to the GNOME developers.