Bug 1701114

Summary:	Deprecation warning for mdmonitor.service's PIDFile (/var/run)
Product:	[Fedora] Fedora	Reporter:	Christian Stadelmann <fedora>
Component:	mdadm	Assignee:	XiaoNi <xni>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	agk, dledford, h.reindl, jes.sorensen, xni
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mdadm-4.1-rc2.0.4.fc30 mdadm-4.1-1.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1704517 (view as bug list)		Environment:
Last Closed:	2020-01-31 02:00:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1704517

Description Christian Stadelmann 2019-04-18 06:31:33 UTC

Steps to reproduce:
1. Have Fedora 30
2. Have mdmonitor.service enabled
3. Boot Fedora 30
4. Watch syslog

what happens:
You'll see this warning by systemd somewhere in the syslog:
> /usr/lib/systemd/system/mdmonitor.service:6: PIDFile= references path below legacy directory /var/run/, updating /var/run/mdadm/mdadm.pid → /run/mdadm/mdadm.pid; please update the unit file accordingly.

What should happen:
No warning

Additional information:
I have created a fix: https://src.fedoraproject.org/rpms/mdadm/pull-request/4

See this similar bug: https://bugzilla.redhat.com/show_bug.cgi?id=1691905

Comment 1 XiaoNi 2019-04-30 02:46:09 UTC

Hi Christian

Could you have a try with this koji.fedoraproject.org/koji/taskinfo?taskID=34539586
This version has your patch.

Thanks
Xiao

Comment 2 Christian Stadelmann 2019-05-09 19:15:37 UTC

I don't see the warning any more.

Comment 3 Christian Stadelmann 2019-12-04 21:11:29 UTC

*** Bug 1704517 has been marked as a duplicate of this bug. ***

Comment 4 Christian Stadelmann 2019-12-04 21:17:59 UTC

This issue has *NOT* been fixed.

Can you please fix this issue? There is a pull request for doing that:
https://src.fedoraproject.org/rpms/mdadm/pull-request/5

Also, please note @orion's comment from that pull request. Why don't you use upstream's mdmonitor.service file?

Comment 5 Christian Stadelmann 2019-12-04 21:18:57 UTC

*** Bug 1716759 has been marked as a duplicate of this bug. ***

Comment 6 Harald Reindl 2019-12-04 23:50:11 UTC

it's amazing how many month *one line fixes* in Fedora take which would have been faced by a proper QA or maintainers which look at their logs long before pushing

Comment 7 Fedora Update System 2020-01-14 01:43:14 UTC

mdadm-4.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-913d180f31

Comment 8 Fedora Update System 2020-01-31 02:00:01 UTC

mdadm-4.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.