Bug 1701121
| Summary: | /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf is a config file, although it's not meant to be | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-provider-ovn | Reporter: | Yedidyah Bar David <didi> |
| Component: | provider | Assignee: | Dominik Holler <dholler> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | msheena |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.2.20 | CC: | bugs, danken, dholler, lsvaty, mduarted, royoung |
| Target Milestone: | ovirt-4.4.0 | Flags: | sbonazzo:
ovirt-4.4?
|
| Target Release: | 1.2.30 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-provider-ovn-1.2.30-1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-20 20:00:37 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
gerrit hook it too greedy I think it would be feasible to always overwrite the ovirt-provider-ovn.conf with the default for the release being installed *if* the current one is backed-up during the upgrade. We could print something to the users during update highlighting this happened, and indicate they would have to merge the two files. This would allow us to remove the ovirt-provider-ovn.conf from the %config section, and provide a way out (I'm aware it's not a perfect one) for the impacted users. We should also add a comment in /etc/ovirt-provider-ovn/setup-ovirt-provider-ovn.conf, that this file might be overwritten during updates. (In reply to Dominik Holler from comment #4) > We should also add a comment in > /etc/ovirt-provider-ovn/setup-ovirt-provider-ovn.conf, that this file might > be overwritten during updates. You might want to do that in 4.3, ASAP, add this to the release notes, and only change it to be non-%config in 4.4. This way, people have better chances to notice. Even the bug is in state MODIFIED, I do not reflect this in the bug state, because this would cause changing to ON_QE before a new version, which contains the related code changes, is released. Verified on =========== ovirt-provider-ovn-1.2.30-1.el8ev.noarch ovirt-engine-4.4.0-0.31.master.el8ev.noarch This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Description of problem: ovirt-provider-ovn's spec file has: %config(noreplace) %{_sysconfdir}/ovirt-provider-ovn Which turns into: # rpm -qc ovirt-provider-ovn /etc/logrotate.d/ovirt-provider-ovn /etc/ovirt-provider-ovn/conf.d/README /etc/ovirt-provider-ovn/logger.conf /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf However, /etc/ovirt-provider-ovn/ovirt-provider-ovn.conf itself was not meant to be so, and the documentation [1] only says to add/change files inside /etc/ovirt-provider-ovn/conf.d . What to do next? If we can be certain that people did not change ovirt-provider-ovn.conf itself, we can simply exclude it from %config in the spec file. If we know that many people did change it, we should probably stop changing it ourselves via rpm updates, and instead create a new file e.g. ovirt-provider-ovn.conf.example or whatever, where we introduce our changes. We then also have to make sure that the defaults for new items are as they are in the .example file, and/or add a new file for defaults inside conf.d. See also: bug 1630824. For that bug, which is about backup/restore, we are going to assume, for now, that it's enough to backup/restore conf.d. If it turns out that we decide to officially support ovirt-provider-ovn.conf as a conf file, we need to patch engine-backup accordingly.