Bug 1701137

python2-ase contains an application. Let that application be provided by python3-ase or ase-gui subpackage and run it on Python 3.

If that is not possible, please let us know.

The specfile has:

# Anyone editing this spec file please make sure the same spec file
# works on other fedora and epel releases, which are supported by this software.
# No quick Rawhide-only fixes will be allowed.

I'll keep this open for another week to give you time to do that, otherwise, I'll just remove the python2 parts.

In this case making the change that only affects Rawhide is OK.
I'll simply not provide any updates for fedora < 30, and python-ase receives no longer updates in epel7 anyway.
The point is that multiple divergent active branches must not be created since I won't maintain them.

I've prepared the switch to python3 and enabled the ase-gui3 component.
It looks like I cannot push any longer to ssh://marcindulak.org/python-ase.git

The modified files are: python-ase.spec and ase-gui.desktop available at

https://koji.fedoraproject.org/koji/taskinfo?taskID=34499236

How can I have the push access to the repository restored?

Created attachment 1559519 [details]
python-ase.spec

Created attachment 1559520 [details]
ase-gui.desktop

> How can I have the push access to the repository restored?

I suggest opening a ticket at https://pagure.io/fedora-infrastructure/issues describing the exact errors you get a command you use.

I also think that the correct git URL is ssh://marcindulak.org/rpms/python-ase.git now.

What is the exact point in this?

# Rename Python 3 scripts
pushd $RPM_BUILD_ROOT/%{_bindir}
for file in `find . -name "ase*"`; do
  mv -fv ${file} `basename $file`3
done
popd

# Link Python 3 scripts
pushd $RPM_BUILD_ROOT/%{_bindir}
for file in `find . -name "ase*3"`; do
  ln -sv ${file} `echo $file | rev | cut -c 2- | rev`
done
popd

This creates softlinks /usr/bin/ase-gui3 -> /usr/bin/ase-gui, etc. for all executable python scripts.

Maybe we could have them called directly /usr/bin/ase-gui - I'm not sure what is the current naming recommendation.

The only reason to have them numbered is to be able to ship both the Python 2 and the Python 3 version. You no longer need that. I suggest to drop the number.

Just make sure the python3-ase package Conflicts: (or Obsoletes:) python2-ase < 3.16.2-6 to provide a clean upgrade path.

The new git url ssh://marcindulak.org/rpms/python-ase.git works

I've removed the /usr/bin/ase*3 links and addeded Obsoletes: python2-ase < 3.16.2-7

Note that the Obsoletes needs to be in the python3-ase package section, otherwise it will be applied only on the main package, but there is no main package.

I've made the change together with a few other new packaging changes in this PR:



https://src.fedoraproject.org/rpms/python-ase/pull-request/2

Merged

Thank You!