Bug 1701330

Summary: [RFE] Filter out ISO and Export storage domains for RHV Infra Mapping wiizard
Product: Red Hat CloudForms Management Engine Reporter: Fabien Dupont <fdupont>
Component: V2VAssignee: Mike Turley <mturley>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.2CC: bthurber, simaishi, ytale
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: All   
OS: All   
Whiteboard: v2v
Fixed In Version: 5.11.0.4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1711032 (view as bug list) Environment:
Last Closed: 2019-12-13 15:09:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1711032    

Description Fabien Dupont 2019-04-18 16:08:26 UTC 
Description of problem:
When creating a RHV Infrastructure Mapping, all the storage domains of the destination provider are listed. However, if one tries to migrate to an ISO or Export domain, the migration will fail. It would be better if only Data storage domains were listed.

Version-Release number of selected component (if applicable): 5.10.2


How reproducible: 100%


Steps to Reproduce:
1. Create a RHV Infrastructure Mapping with wizard
2. Go to the storage mapping screeen

Actual results:
The ISO and Export storage domains of the destination provider are listed.

Expected results:
The ISO and Export storage domains of the destination provider are NOT listed.

Additional info:
When calling the API, it's possible to filter on the 'storage_domain_type' attribute. The only valid value for RHV provider is 'data'.
Comment 2 Mike Turley 2019-05-02 14:15:30 UTC 
PR: https://github.com/ManageIQ/manageiq-v2v/pull/947
Comment 3 Mike Turley 2019-05-13 17:28:38 UTC 
Realized I missed a case, this will need one followup PR.
Comment 4 Mike Turley 2019-05-13 17:40:21 UTC 
In PR#947 I had applied the storage_domain_type filter to all datastores, not just RHV ones. This prevented OSP datastores from appearing in the Wizard.

I corrected the issue in this followup PR: https://github.com/ManageIQ/manageiq-v2v/pull/949
Comment 5 Mike Turley 2019-05-14 13:05:16 UTC 
Both PRs are merged, moving this to POST.
Comment 7 Yadnyawalk Tale 2019-06-14 10:07:44 UTC 
Fixed! Verified on: 5.11.0.8.20190611155126_01e077e 
(Tracker: 5.11 ON_QA day, Thanks Satyajit)