Bug 1701724
| Summary: | CNV Web Console: VM status message | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Avital Pinnick <apinnick> |
| Component: | User Experience | Assignee: | Tomas Jelinek <tjelinek> |
| Status: | CLOSED ERRATA | QA Contact: | Radim Hrazdil <rhrazdil> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.0 | CC: | aos-bugs, cnv-qe-bugs, jokerman, lsurette, mgoldboi, mmccomas, ncredi, rawagner, rhrazdil, yzamir |
| Target Milestone: | --- | ||
| Target Release: | 2.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 2.0.0-14.4 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-07-24 20:15:51 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Avital Pinnick
2019-04-21 08:37:49 UTC
Submitted upstream: https://github.com/kubevirt/web-ui-components/pull/427 Submitted upstream: https://github.com/kubevirt/web-ui-components/pull/447 Removeing ref from this BZ, because it is not back-portable: https://github.com/kubevirt/web-ui-components/pull/427 Merged upstream: https://github.com/kubevirt/web-ui-components/pull/447 Verified that status of VM that is being imported from a VMware instance is now 'VM Importing Pending (VMware)'. However, the wording 'Importing Pending' seems a little odd to me. I believe the usual usage would be 'Import Pending'. This is obviously not a big issue, but I'd like to hear more opinions to see if it's just my feeling. @Liz @Tomas, would you mind sharing your opinion? @Avital, what you think? (In reply to Tomas Jelinek from comment #7) > @Avital, what you think? I agree with Radim. "Importing Pending" sounds strange. "Import Pending" is better. we also have the string: "Importing Error" do we need to change it to "Import Error" ? @Avital @Liz @Radim WDYT ? (In reply to Yaacov Zamir from comment #9) > we also have the string: > "Importing Error" do we need to change it to "Import Error" ? > > @Avital @Liz @Radim WDYT ? What is the full string? What is its context? It probably should be changed because "Importing Error" sounds like we're importing an error, not an error that occurs during importing, but I'd like more info before deciding. @Avital hi, thanks, > What is the full string? What is its context? It's a status indicator and stands by itself, e.g virtual machine state is: "Import Error" / "Running" / "Off" / "Import Pending " etc ... We have PR that adds/update this strings here: https://github.com/kubevirt/web-ui-components/pull/427 File with strings in this PR: https://github.com/kubevirt/web-ui-components/blob/b2aa4332c06bd59017bfe7a7cabd1a48452246e7/src/components/VmStatus/strings.js a - @Avital can you can look at the strings and comment in the PR? > It probably should be changed because "Importing Error" sounds like we're importing an error, +1 Thanks, already updated in the PR. (In reply to Yaacov Zamir from comment #11). > > We have PR that adds/update this strings here: > https://github.com/kubevirt/web-ui-components/pull/427 > > File with strings in this PR: > https://github.com/kubevirt/web-ui-components/blob/ > b2aa4332c06bd59017bfe7a7cabd1a48452246e7/src/components/VmStatus/strings.js > > a - @Avital can you can look at the strings and comment in the PR? I've had a quick look at the strings and made some suggestions. The only one I wasn't sure about is line 24: "export const STARTING_MESSAGE = 'The virtual machine wait for state to become ready.';" If you can respond to my comment in the PR, I'll try to fix that message. Thanks, Changed to "The virtual machine is preparing to start." Verified that VM status is 'Importing (VMware)'. kubevirt-web-ui-container-v2.0.0-14.6. HCO v2.0.0-22. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2019:1850 |