Bug 1702033

New commits detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/e45c1c40b58508ffa8402da3d68efd9eb210fcc8
commit e45c1c40b58508ffa8402da3d68efd9eb210fcc8
Author:     Adam Grare <agrare>
AuthorDate: Tue Mar  5 16:52:01 2019 -0500
Commit:     Adam Grare <agrare>
CommitDate: Tue Mar  5 16:52:01 2019 -0500

    Merge pull request #18505 from djberg96/conversion_host_resource_tag

    Tag associated resource for conversion hosts

    (cherry picked from commit a7b4e8eda1e82f5317dbe0c71c2fd5dc8ea328a5)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702033

 app/models/conversion_host.rb | 31 +-
 spec/models/conversion_host/configurations_spec.rb | 26 +-
 2 files changed, 53 insertions(+), 4 deletions(-)

Created attachment 1561953 [details]
No tags

Hi , 

I have added all the Rhev hosts are conversion hosts.
But they do not shows tagged in UI as in attached screenshot .
tested in 5.10.4.1.20190430152139_40a1d86

ConversionHost.all
=> #<ActiveRecord::Relation [#<ConversionHost id: 1, name: "env-rhv42-01.cfme2.lab.eng.rdu2.redhat.com", address: nil, type: nil, resource_type: "Host", resource_id: 3, version: nil, max_concurrent_tasks: nil, vddk_transport_supported: true, ssh_transport_supported: nil, created_at: "2019-05-02 19:27:36", updated_at: "2019-05-02 19:27:49", concurrent_transformation_limit: nil, cpu_limit: nil, memory_limit: nil, network_limit: nil, blockio_limit: nil>, #<ConversionHost id: 2, name: "env-rhv42-02.cfme2.lab.eng.rdu2.redhat.com", address: nil, type: nil, resource_type: "Host", resource_id: 4, version: nil, max_concurrent_tasks: nil, vddk_transport_supported: true, ssh_transport_supported: nil, created_at: "2019-05-02 19:28:55", updated_at: "2019-05-02 19:29:00", concurrent_transformation_limit: nil, cpu_limit: nil, memory_limit: nil, network_limit: nil, blockio_limit: nil>, #<ConversionHost id: 3, name: "env-rhv42-03.cfme2.lab.eng.rdu2.redhat.com", address: nil, type: nil, resource_type: "Host", resource_id: 5, version: nil, max_concurrent_tasks: nil, vddk_transport_supported: true, ssh_transport_supported: nil, created_at: "2019-05-02 19:29:22", updated_at: "2019-05-02 19:29:28", concurrent_transformation_limit: nil, cpu_limit: nil, memory_limit: nil, network_limit: nil, blockio_limit: nil>]>

I do confirm that it's not needed. Though, we didn't remove the tagging for UI consistency. Two options there: 1. drop tagging of conversion host resource, 2. fix tagging in 5.10.5, as it's not critical.
So, for now, let's move this one to 5.10.5, and decide later.

Moving to 5.10.6 as priority is set on conversion host management UI.

With the UI for Conversion Host management, we don't need tags to identify conversion hosts, so we should drop this feature.
I'm closing as WONTFIX.