Bug 1702085

New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/b34ee8b44080745a2441cbc3bf3be890258637d3
commit b34ee8b44080745a2441cbc3bf3be890258637d3
Author:     Adam Grare <agrare>
AuthorDate: Thu Apr 18 14:15:24 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Thu Apr 18 14:15:24 2019 -0400

    Merge pull request #18576 from fdupont-redhat/v2v_apply_resource_limits_to_virtv2v

    [V2V] Add CPU and network throttling in model

    (cherry picked from commit ce7c67c404127843801f22471f1d286383a9ef17)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702085

 app/models/conversion_host.rb | 21 +
 app/models/job_proxy_dispatcher.rb | 5 +
 lib/infra_conversion_throttler.rb | 44 +
 spec/lib/infra_conversion_throttler_spec.rb | 64 +-
 spec/models/conversion_host_spec.rb | 30 +
 5 files changed, 155 insertions(+), 9 deletions(-)

New commit detected on ManageIQ/manageiq-gems-pending/hammer:

https://github.com/ManageIQ/manageiq-gems-pending/commit/1834a57bbc5e2b16bd047e7f2d3d4846546e179d
commit 1834a57bbc5e2b16bd047e7f2d3d4846546e179d
Author:     Nick Carboni <ncarboni>
AuthorDate: Thu Mar 21 09:32:46 2019 -0400
Commit:     Nick Carboni <ncarboni>
CommitDate: Thu Mar 21 09:32:46 2019 -0400

    Merge pull request #426 from fdupont-redhat/add_put_file_method

    Add put_file method

    (cherry picked from commit 942c1243c081ff0b0165ae26b567126c1ff21e60)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702085

 lib/gems/pending/util/MiqSshUtil.rb | 14 +-
 1 file changed, 12 insertions(+), 2 deletions(-)

New commit detected on ManageIQ/manageiq-v2v/hammer:

https://github.com/ManageIQ/manageiq-v2v/commit/ea0aa2770cedba6d7c4098891e79d64244945652
commit ea0aa2770cedba6d7c4098891e79d64244945652
Author:     Mike Turley <mike.turley.umass.edu>
AuthorDate: Thu Apr 18 14:56:43 2019 -0400
Commit:     Mike Turley <mike.turley.umass.edu>
CommitDate: Thu Apr 18 14:56:43 2019 -0400

    Merge pull request #915 from mzazrivec/add_validation_to_migration_throttling_inputs

    [#911] Add validation to migration throttling inputs and add CPU throttling field

    (cherry picked from commit 03106c9ca7a9c72d54e70c1eddfac9af53f3404f)

    https://bugzilla.redhat.com/show_bug.cgi?id=1702085

 app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsActions.test.js.snap | 2 +
 app/javascript/react/screens/App/Settings/__tests__/__snapshots__/SettingsReducer.test.js.snap | 2 +
 app/javascript/react/screens/App/Settings/helpers.js | 14 +-
 app/javascript/react/screens/App/Settings/screens/GeneralSettings/GeneralSettings.js | 46 +-
 app/javascript/react/screens/App/Settings/screens/GeneralSettings/__tests__/__snapshots__/GeneralSettings.test.js.snap | 18 +
 app/javascript/react/screens/App/Settings/settings.fixures.js | 3 +-
 app/javascript/react/screens/App/common/forms/TextInputWithCheckbox.js | 49 +-
 7 files changed, 81 insertions(+), 53 deletions(-)

The network throttling part of this was not made available in the UI because further backend changes are necessary. See related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1706988

Created attachment 1564740 [details]
5.10.4.1_cpu_issue.png

after consulting with Fabien, moving this to 5.10.5

If we are reverting the backport of https://github.com/ManageIQ/manageiq-v2v/pull/915 we will first need to revert the backport of https://github.com/ManageIQ/manageiq-v2v/pull/943 (https://bugzilla.redhat.com/show_bug.cgi?id=1701376) to prevent conflicts. That layout change is only necessary after this field is added to the form, so it should probably have been considered part of this BZ.

As per discussion with Fabien/Mike, reverted:

https://github.com/ManageIQ/manageiq-v2v/pull/945
https://github.com/ManageIQ/manageiq-v2v/pull/915
https://github.com/ManageIQ/manageiq/pull/18576

Move to 5.10.6 because 5.10.5 focus is conversion host management UI.

Now that this is targeting 5.11.0 is there any reason to have two BZs for it? (this one is also 5.11.0: https://bugzilla.redhat.com/show_bug.cgi?id=1690851)