Bug 1702237

Daniel,
Do we have a way to get this information?
Thanks

(In reply to agjadhav from comment #0)

The storage domain can be retrieved from the 'disk' resource:
e.g. /ovirt-engine/api/disks/123
<disk href="/ovirt-engine/api/disks/123" id="123">
...
  <storage_domains>
    <storage_domain href="/ovirt-engine/api/storagedomains/456" id="456"/>
  </storage_domains>
</disk>

Disk-snapshot resources can be fetched either from the storage domain:
- https://derezengine.usersys:8443/ovirt-engine/api/storagedomains/123/disksnapshots
or directly from the vm snapshot:
- https://derezengine.usersys:8443/ovirt-engine/api/vms/123/snapshots/456/disks

* Is it sufficient for your use case? What is the exact flow?

Hi Ajay,

Can you reply for the above comment?

Best,
Pavan.

Hi Pavan,

The solution suggested is a two step process. First fetch the list of storage domains and then fetch disk info in each storage domain. 
This is a lengthy process to be done when backup process is about to start or is already in progress.

Specifically in case of QCOW2 image transfer, the backup process has already started when we encounter the backing file in it's header.
We need RHV solution to be in the form of just one API call like, image transfer API which takes only "disk_id" as input.

Thanks & Regards,
Ajay Jadhav
(ajay.jadhav)

Thanks Ajay!

@Daniel,

Is comment 4 information sufficient for us to target this for RHV 4.4?

Best,
Pavan.

Hi Ajay,

IIUC, you'd like a new API for getting a disk snapshot directly from the disk entity?
I.e. /ovirt-engine/api/disks/123/disksnapshots/456/

Do you need it only for snapshot creation flow? 
If so, you can try using this API: /ovirt-engine/api/vms/123/snapshots/456/disks
Which should give you information on the disk snapshots.

Hi Daniel,

Pls. see my comments inline,

IIUC, you'd like a new API for getting a disk snapshot directly from the disk entity?
I.e. /ovirt-engine/api/disks/123/disksnapshots/456/

Ajay -> We expect the new API should use the disk_snapshot_id stored in qcow2 backing file.
        This is to retrieve it's provisioned size without iterating through storage domains.

Do you need it only for snapshot creation flow? 
If so, you can try using this API: /ovirt-engine/api/vms/123/snapshots/456/disks
Which should give you information on the disk snapshots.

Ajay -> This API does not help in case of finding the provisioned size of template disk. 
        Also we want to use the API after snapshot operation is complete. i.e. during
        backup phase

Thanks,
Ajay & Gaurav

For comment 7.

Thanks,
Pavan.

For comment 7.

Thanks,
Pavan.

(In reply to agjadhav from comment #7)
> Hi Daniel,
> 
> Pls. see my comments inline,
> 
> IIUC, you'd like a new API for getting a disk snapshot directly from the
> disk entity?
> I.e. /ovirt-engine/api/disks/123/disksnapshots/456/
> 
> Ajay -> We expect the new API should use the disk_snapshot_id stored in
> qcow2 backing file.
>         This is to retrieve it's provisioned size without iterating through
> storage domains.

ok, so it should be available when we introduce a new api:
/ovirt-engine/api/disks/{disk_id}/disksnapshots/{disk_snapshot_id}

I'll define this bug as an RFE for that.

> 
> Do you need it only for snapshot creation flow? 
> If so, you can try using this API:
> /ovirt-engine/api/vms/123/snapshots/456/disks
> Which should give you information on the disk snapshots.
> 
> Ajay -> This API does not help in case of finding the provisioned size of
> template disk. 
>         Also we want to use the API after snapshot operation is complete.
> i.e. during
>         backup phase

Template disks are separated in the API from VM disks.
For querying info on a specific template disk, try the following:

1. List templates disk_attachments: /ovirt-engine/api/templates/{template_id}/diskattachments
2. Get disk href from the disk_attachment.
3. Get disk /ovirt-engine/api/disks/{disk_id}

E.g.
<disk_attachments>
   <disk_attachment href="/ovirt-engine/api/templates/647e7a3d-af49-4be7-8897-9f96d0b4cd05/diskattachments/385019c8-f6d6-498c-8fcb-c14249bbf5d1" id="385019c8-f6d6-498c-8fcb-c14249bbf5d1">
      ...
      <disk href="/ovirt-engine/api/disks/385019c8-f6d6-498c-8fcb-c14249bbf5d1" id="385019c8-f6d6-498c-8fcb-c14249bbf5d1"/>
      <template href="/ovirt-engine/api/templates/647e7a3d-af49-4be7-8897-9f96d0b4cd05" id="647e7a3d-af49-4be7-8897-9f96d0b4cd05"/>
      <vm href="/ovirt-engine/api/vms/647e7a3d-af49-4be7-8897-9f96d0b4cd05" id="647e7a3d-af49-4be7-8897-9f96d0b4cd05"/>
      ...
   </disk_attachment>
</disk_attachments>


> 
> Thanks,
> Ajay & Gaurav

Verified

rhv-4.4.4-3
ovirt-engine-4.4.4.2-0.1.el8ev.noarch
vdsm-4.40.38-1.el8ev.x86_64

<disk_snapshots>
  <disk_snapshot href="/ovirt-engine/api/disks/80cd98ab-0f4c-4bca-818e-396de48a5063/disksnapshots/ed955100-ab6b-4301-97a0-5a81f095fb52" id="ed955100-ab6b-4301-97a0-5a81f095fb52">
    <name>new_vm_from_template_Disk1</name>
    <description></description>
    <actual_size>1073741824</actual_size>
    <alias>new_vm_from_template_Disk1</alias>
    <backup>none</backup>
    <content_type>data</content_type>
    <format>cow</format>
    <propagate_errors>false</propagate_errors>
    <provisioned_size>16106127360</provisioned_size>
    <qcow_version>qcow2_v3</qcow_version>
    <shareable>false</shareable>
    <sparse>true</sparse>
    <status>ok</status>
    <storage_type>image</storage_type>
    <total_size>0</total_size>
    <wipe_after_delete>false</wipe_after_delete>
    <disk_profile href="/ovirt-engine/api/diskprofiles/68daee10-6115-422b-90a3-78641b7619f5" id="68daee10-6115-422b-90a3-78641b7619f5" />
    <quota href="/ovirt-engine/api/datacenters/7e7ffcd1-b1fb-415a-9573-b26b9a28190b/quotas/e6db9e8f-b290-46b1-9d77-0c714c692c3d" id="e6db9e8f-b290-46b1-9d77-0c714c692c3d" />
    <snapshot id="5a4d9314-84a3-4b42-a3be-fa1aba9b2077" />
    <storage_domains>
      <storage_domain href="/ovirt-engine/api/storagedomains/8d0b3973-fa6f-4ae8-b995-b44fc0dd39fb" id="8d0b3973-fa6f-4ae8-b995-b44fc0dd39fb" />
    </storage_domains>
    <disk href="/ovirt-engine/api/disks/80cd98ab-0f4c-4bca-818e-396de48a5063" id="80cd98ab-0f4c-4bca-818e-396de48a5063" />
  </disk_snapshot>
</disk_snapshots>

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: RHV-M(ovirt-engine) 4.4.z security, bug fix, enhancement update [ovirt-4.4.4]), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0381