Bug 1702701

Summary: Review Request: perl-Class-AutoClass - Define classes and objects for Perl
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Class-AutoClass-1.56-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-04-25 14:57:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-04-24 14:00:14 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Class-AutoClass/perl-Class-AutoClass.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Class-AutoClass/perl-Class-AutoClass-1.56-1.fc31.src.rpm
Description:
lass::AutoClass is yet another module that generates standard 'get' and 'set'
methods for Perl classes. It also handles initialization of object and class
data from parameter lists or defaults, and arranges for object creation and
initialization to occur in top-down, textbook order even in the presence of
multiple inheritance.

Fedora Account System Username: ppisar

This package is a rename of perl-AutoClass-1.56-4.fc30 package in order to align with an upstream name.
Comment 1 Robert-André Mauchin 🐧 2019-04-25 00:23:35 UTC 
URL and Source addresses are Ok.
Source archive (SHA-256: 357fc75ba7a49cc5613c30a84898545bd330b697b8ed37be1916bbd72ac3514753f53cbccfd0121c0) is original. Ok.
Summary verified from lib/Class/AutoClass.pm. Ok.
Description verified from lib/Class/AutoClass.pm. Ok.
License verified from lib/Class/AutoClass.pm and README. Ok.
No XS code, noarch BuildArch is Ok.


$ rpmlint perl-Class-AutoClass.spec review-perl-Class-AutoClass/results/perl-Class-AutoClass-1.56-1.fc31.noarch.rpm review-perl-Class-AutoClass/results/perl-Class-AutoClass-1.56-1.fc31.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpm -q -lv -p perl-Class-AutoClass-1.56-1.fc31.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Apr 25 02:10 /usr/share/doc/perl-Class-AutoClass
-rw-r--r--    1 root    root                     4442 Oct  6  2013 /usr/share/doc/perl-Class-AutoClass/Changes
-rw-r--r--    1 root    root                     8850 Apr 25 02:10 /usr/share/man/man3/Class::AutoClass.3pm.gz
drwxr-xr-x    2 root    root                        0 Apr 25 02:10 /usr/share/perl5/vendor_perl/Class
drwxr-xr-x    2 root    root                        0 Apr 25 02:10 /usr/share/perl5/vendor_perl/Class/AutoClass
-rw-r--r--    1 root    root                    51011 Apr 25 02:10 /usr/share/perl5/vendor_perl/Class/AutoClass.pm
-rw-r--r--    1 root    root                     3668 Apr 25 02:10 /usr/share/perl5/vendor_perl/Class/AutoClass/Root.pm
File permissions and layout are Ok.

 $ rpm -q --requires -p perl-Class-AutoClass-1.56-1.fc31.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.28.2)
      1 perl(base)
      1 perl(Carp) >= 1.2
      1 perl(Class::AutoClass::Root)
      1 perl(Hash::AutoHash::Args) >= 1.18
      1 perl(Storable) >= 2.3
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p perl-Class-AutoClass-1.56-1.fc31.noarch.rpm 
perl(Class::AutoClass) = 1.56
perl(Class::AutoClass::Root) = 1.0
perl-AutoClass = 1.56-1.fc31
perl-Class-AutoClass = 1.56-1.fc31
Binary provides are Ok.

Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=34398019).
Ok


Resolution: Packahe approved.
Comment 2 Gwyn Ciesla 2019-04-25 14:31:02 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Class-AutoClass
Comment 3 Petr Pisar 2019-04-25 14:57:29 UTC 
Thank you for the review and the repository. I have retired perl-AutoClass in F31.