Bug 1702863

Description of problem:
When executing the redfish-finder command, it reports "AttributeError: 'USBNetDevice' object has no attribute 'name'".

Version-Release number of selected component (if applicable):
~]# rpm -qa |grep redfish*
redfish-finder-0.2-1.el8.noarch


How reproducible:
Always

Steps to Reproduce:
1. Install redfish-finder package
2. Run the command 'redfish-finder'


Actual results:
Redfish-finder reports the error message shown in the following.

~]# redfish-finder 
redfish-finder: Getting dmidecode info
redfish-finder: Unable to find usb network device with vendor:product 0x4b3:0x4010
redfish-finder: Building NetworkManager connection info
Traceback (most recent call last):
  File "/usr/bin/redfish-finder", line 481, in <module>
    main()
  File "/usr/bin/redfish-finder", line 453, in main
    conn = nmConnection(smbios_info.device)
  File "/usr/bin/redfish-finder", line 350, in __init__
    self.cmdlinedown = "nmcli con down id " + self.ifc.getifcname()
  File "/usr/bin/redfish-finder", line 50, in getifcname
    return self.name
AttributeError: 'USBNetDevice' object has no attribute 'name'


Expected results:
Redfish-finder executes without any failure/error message such as:

~]# ~/adrian/redfish-task/redfish-finder-modified
redfish-finder: Getting dmidecode info
redfish-finder: Building NetworkManager connection info
redfish-finder: Obtaining OS config info
redfish-finder: Converting SMBIOS Host Config to NetworkManager Connection info
redfish-finder: Applying NetworkManager connection configuration changes
Connection 'enp0s20f0u1u6' successfully deactivated (D-Bus active path: /org/freedesktop/NetworkManager/ActiveConnection/14)
Connection successfully activated (D-Bus active path: /org/freedesktop/NetworkManager/ActiveConnection/15)
redfish-finder: Adding redfish host info to OS config
redfish-finder: Done, BMC is now reachable via hostname redfish-localhost


Additional info:
[Finding]
There is a comparison issue for device id and vendor id led to the unexpected result. Neil has fixed the issue accordingly: https://github.com/nhorman/redfish-finder/commit/d4e4d55c8b38c7be11dd85f29408866b1b7f66ab

After applying the above-mentioned commit (Commit id: “d4e4d55”), the issue is fixed.


[dmidecode info]
~]# dmidecode --type 42
# dmidecode 3.2
Getting SMBIOS data from sysfs.
SMBIOS 3.2.1 present.
# SMBIOS implementations newer than version 3.2.0 are not
# fully supported by this version of dmidecode.

Handle 0x2E30, DMI type 42, 169 bytes
Management Controller Host Interface
        Host Interface Type: Network
        Device Type: USB
                idVendor: 0x04b3
                idProduct: 0x4010
                Protocol ID: 04 (Redfish over IP)
                        Service UUID: 94fae9da-1f8e-e811-8b41-7ed30a5e22af
                        Host IP Assignment Type: Static
                        Host IP Address Format: IPv4
                        IPv4 Address: 169.254.95.120
                        IPv4 Mask: 255.255.0.0
                        Redfish Service IP Discovery Type: Static
                        Redfish Service IP Address Format: IPv4
                        IPv4 Redfish Service Address: 169.254.95.118
                        IPv4 Redfish Service Mask: 255.255.0.0
                        Redfish Service Port: 443
                        Redfish Service Vlan: 0
                        Redfish Service Hostname: XCC-7X05-J300CKX8