Bug 1703093

Summary: [v2v] [RFE] Change the layout of the Migration Throttling settings form from horizontal to vertical
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: V2VAssignee: Mike Turley <mturley>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.2CC: bthurber, fdupont, mshriver, mturley, sshveta
Target Milestone: GAKeywords: RFE, ZStream
Target Release: 5.11.z   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1701376 Environment:
Last Closed: 2020-03-18 14:04:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On: 1701376    
Bug Blocks:    
Attachments:
Description Flags
Horizontal layout none

Comment 2 Satoe Imaishi 2019-04-25 15:30:22 UTC
https://github.com/ManageIQ/manageiq-v2v/pull/945

Comment 3 Shveta 2019-05-02 21:12:09 UTC
Created attachment 1562001 [details]
Horizontal layout

Verified in 5.10.4.1.20190430152139_40a1d86

Comment 4 Satoe Imaishi 2019-05-07 22:23:37 UTC
As per discussion with Fabien/Mike, reverted https://github.com/ManageIQ/manageiq-v2v/pull/945

commit 8104bb0c4dceb5e41387c9dfd21d3fd0c731363a
Author: Satoe Imaishi <simaishi>
Date:   Tue May 7 18:17:17 2019 -0400

    Revert "Merge pull request #945 from mturley/hammer-throttling-settings-vertical-layout"
    
    This reverts commit b74dc63315ef7828569b7ad31f8d0a15220cf9fa, reversing
    changes made to ea0aa2770cedba6d7c4098891e79d64244945652.

Comment 8 Mike Turley 2019-06-10 17:29:45 UTC
The PR for this change depends on this PR: https://github.com/ManageIQ/manageiq-v2v/pull/915 which adds the CPU throttling field to settings. We'll need to backport that PR before this one, but that PR's BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1690851) is targeted for 5.11.
This is a purely cosmetic change that only became necessary after we added the CPU throttling field, so I'll update its target release to 5.11. I have a related concern about the other BZ which I'll address in a comment there.

Comment 10 Fabien Dupont 2020-03-18 08:29:00 UTC
Mike, can it be closed as CURRENTRELEASE?

Comment 11 Mike Turley 2020-03-18 14:04:17 UTC
Yes, in fact this was backported to Hammer (https://github.com/ManageIQ/manageiq-v2v/pull/943).

Comment 12 Mike Turley 2020-03-18 14:04:45 UTC
Yes, in fact this was backported to Hammer (https://github.com/ManageIQ/manageiq-v2v/pull/943).

Comment 13 Mike Turley 2020-03-18 14:06:13 UTC
Oops, double post. Bugzilla is having a bad time today :)