Bug 1703715

Created attachment 1559848 [details]
Check if System.map file exists and set system_map_file_option for depmod accordingly (RHBZ#1703715).

Hello,

Thanks for reporting this issue.

Here is a proposed patch to address this problem. It has to be applied to the kmodtool shell script.

Hope this will fix your issue.

Feedback is welcome.

Cordially,


-- 
NVieville

Hello Nicolas,

thank you very much for the patch.  After applying it cleanly on top of an installation of
`kmodtool-1-33.fc29.noarch.rpm` and making sure that neither any `kmod-*`
package is installed nor that there are stale rpm files within the  `/var/cache/akmods` directory,
`akmods` now creates rpm files with the proper post{,un}install scripts for my setup.

So the patch works for me without issues.

regards,

Marcel

Created attachment 1560442 [details]
Check if System.map file exists and set system_map_file_option for depmod accordingly (RHBZ#1703715).

Hello Marcel,

Thank you for testing this patch and your feedback.

Here is, as an attachment, the patch I submitted as a pull request (in order to review it). It does the same as the previous one but uses a RPM macro expanded at install time of the kmod-foo package instead of build time.

I wonder if you could please give it a try, and provide feedback. That's not a problem if you don't have time for it.

Cordially,


-- 
NVieville

I still don't get why yet another crazy echoed macro... /:


Why it's not such a dead simple solution ?!?
---
 %post          -n kmod-${kmodname}
if [ -f /boot/System.map-${kernel_uname_r} ] ; then
 %{?_prefix_usr}/sbin/depmod -aeF /boot/System.map-${kernel_uname_r} ${kernel_uname_r} > /dev/null
elif [ -f /lib/modules/${kernel_uname_r}/System.map ] ; then
 %{?_prefix_usr}/sbin/depmod -aeF /lib/modules/${kernel_uname_r}/System.map ${kernel_uname_r} > /dev/null
else 
 %{?_prefix_usr}/sbin/depmod -a
fi || :
---
etc

Hello Nicolas,

(In reply to Nicolas Chauvet (kwizart) from comment #4)
> I still don't get why yet another crazy echoed macro... /:

Because this has to be done in %post and %postun sections, and I thought
it was better to be short rather than get the risk of repeating two
identical pieces of code with the well-known problems of copying/pasting,
or the long term later modifications.

There seems I was wrong!

> Why it's not such a dead simple solution ?!?
> ---
>  %post          -n kmod-${kmodname}
> if [ -f /boot/System.map-${kernel_uname_r} ] ; then
>  %{?_prefix_usr}/sbin/depmod -aeF /boot/System.map-${kernel_uname_r}
> ${kernel_uname_r} > /dev/null
> elif [ -f /lib/modules/${kernel_uname_r}/System.map ] ; then
>  %{?_prefix_usr}/sbin/depmod -aeF /lib/modules/${kernel_uname_r}/System.map
> ${kernel_uname_r} > /dev/null
> else 
>  %{?_prefix_usr}/sbin/depmod -a
> fi || :
> ---
> etc

If you think this is the way for both sections (post and postun), so let's 
go.

Cordially,


-- 
NVieville

kmodtool-1-34.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a96c293fab

kmodtool-1-34.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a96c293fab

kmodtool-1-34.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.