Bug 1704432 (rust-libhandy-sys)

Summary: Review Request: rust-libhandy-sys - Sys part of the rust bindings for libhandy
Product: [Fedora] Fedora Reporter: Artem <ego.cordatus>
Component: Package ReviewAssignee: Igor Raits <igor.raits>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: igor.raits, package-review, zebob.m
Target Milestone: ---Flags: igor.raits: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-05 20:04:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Artem 2019-04-29 18:05:38 UTC
Spec URL: https://atim.fedorapeople.org/for-review/rust-libhandy-sys.spec
SRPM URL: https://atim.fedorapeople.org/for-review/rust-libhandy-sys-0.3.0-1.fc30.src.rpm

Description:
The sys part of the rust bindings for libhandy

Fedora Account System Username: atim

Working COPR: https://copr.fedorainfracloud.org/coprs/atim/rust-crates/

Comment 1 Robert-André Mauchin 🐧 2019-05-01 22:36:00 UTC
 - You didn't fix the License field:

License:        GPL-3.0-or-later
# FIXME: Upstream uses unknown SPDX tag GPL-3.0-or-later!

should be:

License:        GPLv3+

 - Ask upstream for a LICENSE file and add the bug request link to your SPEC in the meantime.


 - No 

Requires:       pkgconfig(libhandy-0.0) >= 0.0.6

   for %package     -n %{name}+v0_0_6-devel ?

Comment 3 Igor Raits 2019-05-05 15:20:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libhandy-sys