Bug 1704806

Created from redmine issue https://projects.theforeman.org/issues/26702

Upstream bug assigned to egolov

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/26702 has been resolved.

Hi Evgeni,

For verification, Do I need to check into the satellite-installer log and verify the content's that you mentioned in the description or perform satellite installation with some specific parameter to check installation should work or not?

Hey Devendra,

so *technically* doing a grep in /usr/share/foreman-installer-katello (or whatever the correct path is, I never can remember that) and verify that all files refer to the same spelling of the param should be sufficient.

If you'd want to be super precise, you'd need to install a 6.3 (the last version that installed MMAPv1 by default), upgrade that all the way to 6.6, verify that the logs from the 6.6 upgrade contain the right name, execute the upgrade, then verify that custom-hiera.yaml also contains the right name.
But I see no benefit in doing that over the simple grep :)

Hope this helps
Evgeni

(In reply to Evgeni Golov from comment #6)
> Hey Devendra,
> 
> so *technically* doing a grep in /usr/share/foreman-installer-katello (or
> whatever the correct path is, I never can remember that) and verify that all
> files refer to the same spelling of the param should be sufficient.
> 
> If you'd want to be super precise, you'd need to install a 6.3 (the last
> version that installed MMAPv1 by default), upgrade that all the way to 6.6,
> verify that the logs from the 6.6 upgrade contain the right name, execute
> the upgrade, then verify that custom-hiera.yaml also contains the right name.
> But I see no benefit in doing that over the simple grep :)
> 
> Hope this helps
> Evgeni

Thanks Evgeni for the update.

I am still getting "--upgrade-mongo-storage" statement in /etc/foreman-installer/custom-hiera.yaml file in commented part after mongo-storage-engine upgrade.
I think we should need to update it to "--upgrade-mongo-storage-engine" right?

(In reply to Devendra Singh from comment #8)
> I am still getting "--upgrade-mongo-storage" statement in
> /etc/foreman-installer/custom-hiera.yaml file in commented part after
> mongo-storage-engine upgrade.
> I think we should need to update it to "--upgrade-mongo-storage-engine"
> right?

Yes, and my commit upstream does that. However, it does only add that once (when you update from 6.3 to 6.4), so any newer updates don't update the comment.

(In reply to Evgeni Golov from comment #9)
> (In reply to Devendra Singh from comment #8)
> > I am still getting "--upgrade-mongo-storage" statement in
> > /etc/foreman-installer/custom-hiera.yaml file in commented part after
> > mongo-storage-engine upgrade.
> > I think we should need to update it to "--upgrade-mongo-storage-engine"
> > right?
> 
> Yes, and my commit upstream does that. However, it does only add that once
> (when you update from 6.3 to 6.4), so any newer updates don't update the
> comment.

So how would I fix it if my system was upgraded from 6.3 to 6.4 and the fix introduces latter?

FailedQA.

During verification, I faced an inconsistent naming related issue(for mongo DB upgrade) in the custom-hiera.yml file in mongodb comment section

Expected Result: # Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage-engine to upgrade to WiredTiger.
Actual Result: # Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger.

Context from a mail I sent to Devendra last week:

So I wanted to write "does this need fixing", but then I looked at the code ;-)
The current workflow is:
1/ the user has a old installation with MongoDB MMAPv1 storage (so 6.3)
2/ during the upgrade to 6.4 they get a "Added by foreman-installer
during upgrade, run the installer with --upgrade-mongo-storage-engine
to upgrade to WiredTiger" comment added to custom-hiera by the
installer
3/ they upgrade to 6.5 (no changes here)
4/ they upgrade to 6.6 (again, no changes for now)
At this point they can remain on MMAPv1 storage and will still have
the "wrong" comment in the file, but that doesn't *really* harm
anybody (the Installer logs will have a warning with the right
command)
Or they will try the upgrade (and find out the right command name) and
end up with wiredTiger storage. However, as they had the "wrong"
comment in the file, it will not be replaced to "Do not remove" (see
https://github.com/theforeman/foreman-installer/pull/349/files#diff-ceb7d70cfab1a466aef1539a90401046R60)
as that replacement expects the "right" command in the comment.

I think *THAT* is something we should fix by allowing the replacement
of both wrong and correct comments. But fixing the existing comment is
IMHO too much code for a simple comment :)

manual post because failedqa previously

FailedQA.

The problem still exists in the latest snap.

Expected Result: # Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage-engine to upgrade to WiredTiger.
Actual Result: # Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger.

This looks like it was wrongly cherry-picked.

Verified successfully.
Satellite version: 6.6.0 
Foreman-installer version: foreman-installer-1.22.0.16-1.el7sat.noarch

Now the custom-hiera.yaml file updated successfully after the mongo DB engine upgrade 

Before mongo DB storage engine upgrade:

# Added by foreman-installer during upgrade, run the installer with --upgrade-mongo-storage to upgrade to WiredTiger.
mongodb::server::storage_engine: 'mmapv1'

After mongo DB storage engine upgrade:

# Do not remove
mongodb::server::storage_engine: 'wiredTiger'

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:3172